Bug 156275

Summary:

Web Inspector: protocol generator should emit an error when 'type' is used instead of '$ref'

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

147067

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2016-04-05 20:00:43 PDT

Found by Joe here: https://bugs.webkit.org/attachment.cgi?id=275721&action=review

Comment 1 Radar WebKit Bug Importer 2016-04-05 20:01:37 PDT

<rdar://problem/25569331>

Comment 2 BJ Burg 2016-04-06 08:39:28 PDT

It looks like in TypeReference.__init__, we never check whether the type_kind is valid. Then we return it as the fallback if the type_reference (i.e., $ref) is not set.

Comment 3 BJ Burg 2016-04-07 21:26:44 PDT

Created attachment 275979 [details]
Proposed Fix

Comment 4 WebKit Commit Bot 2016-04-07 21:28:44 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 5 WebKit Commit Bot 2016-04-08 00:13:29 PDT

Comment on attachment 275979 [details]
Proposed Fix

Clearing flags on attachment: 275979

Committed r199219: <http://trac.webkit.org/changeset/199219>

Comment 6 WebKit Commit Bot 2016-04-08 00:13:33 PDT

All reviewed patches have been landed.  Closing bug.