Bug 156258

Summary: Web Inspector: Command-Option-R opens Inspector details sidebar or Responsive Design Mode, should only do one
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+

Timothy Hatcher
Reported 2016-04-05 16:11:21 PDT
The short cut Cmd + Opt + R is mapped to Responsive mode but if the Web Inspector is open then the right side bar toggles open and shut with the same Cmd + Opt + R shortcut. The computer doesn't go into Responsive mode. One has to close the inspector, and then use the shortcut else use the dropdown menu. Steps to Reproduce: 1. Open Safari 2. Open any webpage 3. Open the Web Inspector 4. Press the shortcut Cmd + Opt + R (it will toggle the details sidebar) 5. Close Web inspector (unnecessary step) 6. Press Cmd + Opt + R for responsive mode. <rdar://problem/25483871>
Attachments
Patch (2.77 KB, patch)
2016-04-05 16:15 PDT, Timothy Hatcher 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2016-04-05 16:15:47 PDT
Created attachment 275710 [details] Patch
Joseph Pecoraro
Comment 2 2016-04-05 16:17:10 PDT
Comment on attachment 275710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275710&action=review Seems fine > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Command-Option-R opens Inspector details sidebar or Respinsive Design Mode, should only do one Typo: Respinsive => "Responsive"
Timothy Hatcher
Comment 3 2016-04-05 16:20:47 PDT
https://trac.webkit.org/r199082
Note You need to log in before you can comment on or make changes to this bug.