Summary: | Shadow DOM: :host() From The First Shadow Context Should Not Style All Shadow Context | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | rniwa, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2016-04-05 08:55:14 PDT
Created attachment 275668 [details]
test
Created attachment 275669 [details]
patch
Comment on attachment 275669 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275669&action=review r=me > Source/WebCore/style/StyleSharingResolver.cpp:100 > + if (element.shadowRoot() && !element.shadowRoot()->styleResolver().ruleSets().authorStyle()->hostPseudoClassRules().isEmpty()) This would look so nice if we made authorStyle() return a reference, too. > Source/WebCore/style/StyleSharingResolver.cpp:287 > + if (element.shadowRoot() && !element.shadowRoot()->styleResolver().ruleSets().authorStyle()->hostPseudoClassRules().isEmpty()) Mhm. Comment on attachment 275669 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275669&action=review > Source/WebCore/style/StyleSharingResolver.cpp:288 > + return nullptr; nullptr -> false :( > nullptr -> false > :( http://trac.webkit.org/changeset/199584 |