Summary: | jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 156324 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ryan Haddad
2016-04-04 16:27:43 PDT
I'll look into this *** Bug 156239 has been marked as a duplicate of this bug. *** Created attachment 275679 [details]
patch
Comment on attachment 275679 [details]
patch
LGTM too.
I'm going to try to test/repro locally first. I can't repro locally. Let's land this speculatively and see if it fixes things. Comment on attachment 275679 [details] patch Clearing flags on attachment: 275679 Committed r199070: <http://trac.webkit.org/changeset/199070> All reviewed patches have been landed. Closing bug. r199070 does not appear to have resolved the issue, as the tests are still timing out: <https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/5514> Created attachment 275839 [details]
patch
attempt #2 at preventing the timeout.
For the record, the timeout is purely because
the test runs out of time on a busy machine.
When giving the test infinite time to run, it takes
about 4 minutes to finish.
Comment on attachment 275839 [details]
patch
r=me
Comment on attachment 275839 [details] patch Clearing flags on attachment: 275839 Committed r199135: <http://trac.webkit.org/changeset/199135> All reviewed patches have been landed. Closing bug. |