Bug 156166

Summary: [WebGL2] Allow enabling WebGL2 with a runtime flag
Product: WebKit Reporter: Antoine Quint <graouts>
Component: WebGLAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dino, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156061    
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2016-04-04 07:09:56 PDT
Alexey suggested in https://bugs.webkit.org/show_bug.cgi?id=156061 that we should be using a runtime flag for WebGL2 work. This task covers specifically the addition of a runtime flag.
Attachments
Patch (16.59 KB, patch)
2016-04-05 02:16 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.50 KB, patch)
2016-04-05 03:21 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-04 07:10:26 PDT
<rdar://problem/25526929>
Antoine Quint
Comment 2 2016-04-05 02:16:40 PDT
Created attachment 275651 [details] Patch
WebKit Commit Bot
Comment 3 2016-04-05 02:18:59 PDT
Attachment 275651 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:11: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 4 2016-04-05 02:39:49 PDT
Comment on attachment 275651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275651&action=review > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:206 > +#if ENABLE(ENABLE_WEBGL2) This should be ENABLE(WEBGL2). There are a few of these in the patch.
Antoine Quint
Comment 5 2016-04-05 03:21:52 PDT
Created attachment 275655 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-04-05 04:22:21 PDT
Comment on attachment 275655 [details] Patch for landing Clearing flags on attachment: 275655 Committed r199055: <http://trac.webkit.org/changeset/199055>
WebKit Commit Bot
Comment 7 2016-04-05 04:22:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.