Bug 156144

Summary:

Shadow DOM: Slot style is not computed

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

157516

Bug Blocks:

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
patch	darin: review+

Description Antti Koivisto 2016-04-03 04:20:38 PDT

We don’t currently compute style for active slots. While slots have have implicit display:contents and don’t create boxes themselves the style should still inherit to slotted children.

Basically

<slot style=“color:red”></slot>

should work as expected.

Comment 1 Antti Koivisto 2016-04-03 04:22:21 PDT

rdar://problem/25238498

Comment 2 Antti Koivisto 2016-04-03 04:40:51 PDT

Created attachment 275495 [details]
patch

Comment 3 Build Bot 2016-04-03 05:24:13 PDT

Comment on attachment 275495 [details]
patch

Attachment 275495 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1092099

New failing tests:
fast/shadow-dom/css-scoping-shadow-slot-style.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 4 Build Bot 2016-04-03 05:24:17 PDT

Created attachment 275496 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 5 Build Bot 2016-04-03 05:27:05 PDT

Comment on attachment 275495 [details]
patch

Attachment 275495 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1092104

New failing tests:
fast/shadow-dom/css-scoping-shadow-slot-style.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 6 Build Bot 2016-04-03 05:27:09 PDT

Created attachment 275497 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 7 Build Bot 2016-04-03 05:32:06 PDT

Comment on attachment 275495 [details]
patch

Attachment 275495 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1092102

New failing tests:
fast/shadow-dom/css-scoping-shadow-slot-style.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 8 Build Bot 2016-04-03 05:32:10 PDT

Created attachment 275498 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

Comment 9 Build Bot 2016-04-03 05:37:52 PDT

Comment on attachment 275495 [details]
patch

Attachment 275495 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1092115

New failing tests:
fast/shadow-dom/css-scoping-shadow-slot-style.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

Comment 10 Build Bot 2016-04-03 05:37:56 PDT

Created attachment 275499 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 11 Antti Koivisto 2016-04-03 08:03:04 PDT

Created attachment 275500 [details]
patch

Comment 12 Antti Koivisto 2016-04-03 13:20:18 PDT

https://trac.webkit.org/r198990