Bug 156138

Summary:

REGRESSION (r198933): Web Inspector and inspected page hang in local builds

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Web Inspector

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bburg, bfulgham, graouts, joepeck, mattbaker, nvasilyev, oliver, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Local Build

Hardware:

Mac

OS:

OS X 10.11

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2016-04-02 14:32:50 PDT

Following r198933, inspecting a page can cause the Web Inspector to hang.

Steps to reproduce:

1. Tools/run-safari --release
2. Inspect daringfireball.net.
3. In the Web Inspector console, evaluate "1".

Then the Web Inspector hangs and error messages are seen in the system console that have the form:

Apr  2 13:51:52 plasma com.apple.WebKit.Databases.Development[43346]: com.apple.WebKit.Databases.Development: Code signing identifier of client differs from passed client identifier: -2147416000
Apr  2 13:51:52 plasma com.apple.xpc.launchd[1] (com.apple.WebKit.Databases.Development.8E815E0B-0048-46B7-8EAA-1E72B28EE10A[43346]): Service exited with abnormal code: 77
Apr  2 13:51:52 plasma sandboxd[144] ([43346]): com.apple.WebKit(43346) deny file-read-data /private/var/db/DetachedSignatures
Apr  2 13:51:52 plasma sandboxd[144] ([43346]): com.apple.WebKit(43346) deny mach-lookup com.apple.SecurityServer

Comment 1 Daniel Bates 2016-04-02 14:33:05 PDT

<rdar://problem/25507724>

Comment 2 Daniel Bates 2016-04-02 14:37:20 PDT

Created attachment 275485 [details]
Patch

Comment 3 Daniel Bates 2016-04-02 14:42:21 PDT

I came up with this policy by trial and error until the I no longer saw any error messages in the system console when following the reproduction steps (comment 0). Let me know if I may be missing something or if it is preferred to adopt the Security framework sandbox policies that the WebProcess/Network process use <http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in?rev=198054#L204>.

Comment 4 Daniel Bates 2016-04-02 15:04:42 PDT

Comment on attachment 275485 [details]
Patch

Clearing flags on attachment: 275485

Committed r198977: <http://trac.webkit.org/changeset/198977>

Comment 5 Daniel Bates 2016-04-02 15:04:46 PDT

All reviewed patches have been landed.  Closing bug.