Bug 156107

Summary:

Use RenderTreeUpdater for text node mutations

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, kangil.han, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	kling: review+
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews112 for mac-yosemite	none
patch	none

Antti Koivisto

Reported 2016-04-01 04:52:45 PDT

Get rid of the awkward special code paths for this.

Attachments
patch (14.03 KB, patch) 2016-04-04 09:34 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (30.81 KB, patch) 2016-04-04 09:36 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
patch (31.86 KB, patch) 2016-04-04 10:10 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.35 MB, application/zip) 2016-04-04 10:55 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.24 MB, application/zip) 2016-04-04 11:19 PDT, Build Bot	no flags	Details
patch (35.12 KB, patch) 2016-04-05 02:35 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-04-04 09:34:48 PDT

Created attachment 275552 [details] patch

Antti Koivisto

Comment 2 2016-04-04 09:36:03 PDT

Created attachment 275553 [details] patch

Andreas Kling

Comment 3 2016-04-04 10:03:05 PDT

Comment on attachment 275553 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275553&action=review r=me. Very tasty :) > Source/WebCore/ChangeLog:8 > + Use the new mechanism for updating render tree after text node conntent changes. >conntent

Antti Koivisto

Comment 4 2016-04-04 10:10:12 PDT

Created attachment 275556 [details] patch

Build Bot

Comment 5 2016-04-04 10:55:42 PDT

Comment on attachment 275556 [details] patch Attachment 275556 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1098793 New failing tests: fast/dom/beforeload/remove-flash-in-beforeload-listener.html editing/mac/spelling/autocorrection-simple.html editing/mac/spelling/autocorrection-contraction.html editing/mac/spelling/autocorrection-removing-underline.html editing/mac/spelling/autocorrection-removing-underline-after-paste.html

Build Bot

Comment 6 2016-04-04 10:55:46 PDT

Created attachment 275559 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-04-04 11:18:58 PDT

Comment on attachment 275556 [details] patch Attachment 275556 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1098846 New failing tests: fast/dom/beforeload/remove-flash-in-beforeload-listener.html editing/mac/spelling/autocorrection-simple.html editing/mac/spelling/autocorrection-contraction.html editing/mac/spelling/autocorrection-removing-underline.html editing/mac/spelling/autocorrection-removing-underline-after-paste.html

Build Bot

Comment 8 2016-04-04 11:19:03 PDT

Created attachment 275560 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 9 2016-04-05 02:35:27 PDT

Created attachment 275652 [details] patch

Antti Koivisto

Comment 10 2016-04-05 03:30:09 PDT

https://trac.webkit.org/r199054

Note You need to log in before you can comment on or make changes to this bug.