Bug 156083

Summary:

Web Automation: the interaction queue in WebAutomationSession::performKeyboardInteractions doesn't work

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	timothy: review+

Description BJ Burg 2016-03-31 14:20:28 PDT

Whoops,

Comment 1 Radar WebKit Bug Importer 2016-03-31 14:21:16 PDT

<rdar://problem/25473518>

Comment 2 BJ Burg 2016-03-31 14:22:32 PDT

Created attachment 275326 [details]
Patch

Comment 3 Timothy Hatcher 2016-03-31 14:26:11 PDT

Comment on attachment 275326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275326&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:750
> +    actionsToPerform.reserveCapacity(interactions.length());

You can use uncheckedAppend in the loop since you do this.

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:752
>      for (auto it = interactions.begin(); it != interactions.end(); ++it) {

for (auto& interaction : interactions) {

Comment 4 BJ Burg 2016-03-31 14:51:37 PDT

Committed r198918: <http://trac.webkit.org/changeset/198918>