Bug 156083

Summary: Web Automation: the interaction queue in WebAutomationSession::performKeyboardInteractions doesn't work
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch timothy: review+

Blaze Burg
Reported 2016-03-31 14:20:28 PDT
Whoops,
Attachments
Patch (2.37 KB, patch)
2016-03-31 14:22 PDT, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-31 14:21:16 PDT
<rdar://problem/25473518>
Blaze Burg
Comment 2 2016-03-31 14:22:32 PDT
Created attachment 275326 [details] Patch
Timothy Hatcher
Comment 3 2016-03-31 14:26:11 PDT
Comment on attachment 275326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275326&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:750 > + actionsToPerform.reserveCapacity(interactions.length()); You can use uncheckedAppend in the loop since you do this. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:752 > for (auto it = interactions.begin(); it != interactions.end(); ++it) { for (auto& interaction : interactions) {
Blaze Burg
Comment 4 2016-03-31 14:51:37 PDT
Committed r198918: <http://trac.webkit.org/changeset/198918>
Note You need to log in before you can comment on or make changes to this bug.