Description
Antoine Quint
2016-03-31 06:08:03 PDT
Created attachment 275278 [details]
Patch
Created attachment 275293 [details]
Patch
Comment on attachment 275293 [details] Patch Attachment 275293 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1076019 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275299 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 275319 [details]
Patch
Comment on attachment 275319 [details] Patch Attachment 275319 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1077114 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275328 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275319 [details] Patch Attachment 275319 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1077118 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275330 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275319 [details] Patch Attachment 275319 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1077143 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275332 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275319 [details]
Patch
Test failures seem unrelated, but please double check before landing.
r=me
Comment on attachment 275319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275319&action=review looks good. > Source/WebCore/html/HTMLCanvasElement.cpp:300 > || type == "experimental-webgl2" We should get rid of this line. > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:407 > - if (type == "experimental-webgl2") > + if (type == "webgl2" || type == "experimental-webgl2") Get rid of experimental-webgl2 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:430 > - if (type == "experimental-webgl2") > + if (type == "webgl2" || type == "experimental-webgl2") Ditto. Comment on attachment 275319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275319&action=review > Source/JavaScriptCore/ChangeLog:5 > + https://bugs.webkit.org/show_bug.cgi?id=156061 > + Add the <rdar://problem/25463193> on the line just under the bugzilla link. (In reply to comment #13) > Comment on attachment 275319 [details] > Patch > > Test failures seem unrelated, but please double check before landing. > r=me They are, and new baselines are needed: --- /Volumes/Data/EWS/WebKit/WebKitBuild/Debug/layout-test-results/js/dom/global-constructors-attributes-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Debug/layout-test-results/js/dom/global-constructors-attributes-actual.txt @@ -2113,6 +2113,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'WeakSet').hasOwnProperty('set') is false PASS Object.getOwnPropertyDescriptor(global, 'WeakSet').enumerable is false PASS Object.getOwnPropertyDescriptor(global, 'WeakSet').configurable is true +PASS Object.getOwnPropertyDescriptor(global, 'WebGL2RenderingContext').value is WebGL2RenderingContext +PASS Object.getOwnPropertyDescriptor(global, 'WebGL2RenderingContext').hasOwnProperty('get') is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGL2RenderingContext').hasOwnProperty('set') is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGL2RenderingContext').enumerable is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGL2RenderingContext').configurable is true PASS Object.getOwnPropertyDescriptor(global, 'WebGLActiveInfo').value is WebGLActiveInfo PASS Object.getOwnPropertyDescriptor(global, 'WebGLActiveInfo').hasOwnProperty('get') is false PASS Object.getOwnPropertyDescriptor(global, 'WebGLActiveInfo').hasOwnProperty('set') is false @@ -2188,6 +2193,11 @@ PASS Object.getOwnPropertyDescriptor(global, 'WebGLUniformLocation').hasOwnProperty('set') is false PASS Object.getOwnPropertyDescriptor(global, 'WebGLUniformLocation').enumerable is false PASS Object.getOwnPropertyDescriptor(global, 'WebGLUniformLocation').configurable is true +PASS Object.getOwnPropertyDescriptor(global, 'WebGLVertexArrayObject').value is WebGLVertexArrayObject +PASS Object.getOwnPropertyDescriptor(global, 'WebGLVertexArrayObject').hasOwnProperty('get') is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGLVertexArrayObject').hasOwnProperty('set') is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGLVertexArrayObject').enumerable is false +PASS Object.getOwnPropertyDescriptor(global, 'WebGLVertexArrayObject').configurable is true PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').value is WebKitAnimationEvent PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').hasOwnProperty('get') is false PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').hasOwnProperty('set') is false Created attachment 275402 [details]
Patch
Comment on attachment 275402 [details] Patch Attachment 275402 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1081146 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275403 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 275404 [details]
Patch
Comment on attachment 275404 [details] Patch Attachment 275404 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1081382 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275407 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275404 [details] Patch Attachment 275404 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1081381 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275408 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275404 [details] Patch Attachment 275404 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1081393 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275409 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 275410 [details]
Patch
Comment on attachment 275410 [details] Patch Attachment 275410 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1081955 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275412 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275410 [details] Patch Attachment 275410 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1081960 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275414 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275410 [details] Patch Attachment 275410 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1081998 New failing tests: js/dom/global-constructors-attributes.html transitions/default-timing-function.html Created attachment 275418 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275410 [details]
Patch
Enabling an unimplemented feature is not right. All users of nightlies and Safari Tech Preview will get it.
The right way to do testing at early stages is to have a runtime option, enabled in WebKitTestRunner and DumpRenderTree.
Created attachment 275533 [details]
Patch
Comment on attachment 275533 [details] Patch Attachment 275533 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1096756 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275538 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275533 [details] Patch Attachment 275533 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1096759 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275539 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275533 [details] Patch Attachment 275533 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1096768 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275541 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #34) > Comment on attachment 275410 [details] > Patch > > Enabling an unimplemented feature is not right. All users of nightlies and > Safari Tech Preview will get it. > > The right way to do testing at early stages is to have a runtime option, > enabled in WebKitTestRunner and DumpRenderTree. Good point. Will cover this in https://bugs.webkit.org/show_bug.cgi?id=156166 and ensure this is landed before this bug lands. Created attachment 275548 [details]
Another try at making the bots happy
Comment on attachment 275548 [details] Another try at making the bots happy View in context: https://bugs.webkit.org/attachment.cgi?id=275548&action=review cq- because this can't land before a runtime option is added. > Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:58 > +#include <JavaScriptCore/GenericTypedArrayViewInlines.h> > +#include <JavaScriptCore/JSGenericTypedArrayViewInlines.h> I think that this works for Cocoa builds, but for Linux builds, the files should have wrappers in ForwardingHeaders, and should be includes as "runtime/GenericTypedArrayViewInlines.h". Windows may have a different yet way to do forwarding headers. Comment on attachment 275548 [details] Another try at making the bots happy View in context: https://bugs.webkit.org/attachment.cgi?id=275548&action=review > LayoutTests/webgl/webgl2-context.html:7 > +if (typeof WebGL2RenderingContext === "undefined" || !(document.createElement("canvas").getContext("webgl2") instanceof WebGL2RenderingContext)) > + document.getElementById("result").innerHTML = "FAIL"; It would be nice to have this as two separate sub-tests, to make it easier to know which part failed. (In reply to comment #45) > Comment on attachment 275548 [details] > Another try at making the bots happy > > View in context: > https://bugs.webkit.org/attachment.cgi?id=275548&action=review > > > LayoutTests/webgl/webgl2-context.html:7 > > +if (typeof WebGL2RenderingContext === "undefined" || !(document.createElement("canvas").getContext("webgl2") instanceof WebGL2RenderingContext)) > > + document.getElementById("result").innerHTML = "FAIL"; > > It would be nice to have this as two separate sub-tests, to make it easier > to know which part failed. I'll do this when I land the patch. Created attachment 275660 [details]
Patch
Comment on attachment 275660 [details] Patch Clearing flags on attachment: 275660 Committed r199062: <http://trac.webkit.org/changeset/199062> All reviewed patches have been landed. Closing bug. |