Bug 155993

Summary: bmalloc: page size should be configurable at runtime
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: bmallocAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, kling, msaboff, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Geoffrey Garen
Reported 2016-03-29 16:09:38 PDT
bmalloc: page size should be configurable at runtime
Attachments
Patch (20.48 KB, patch)
2016-03-29 16:26 PDT, Geoffrey Garen 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-03-29 16:26:38 PDT
Created attachment 275146 [details] Patch
Andreas Kling
Comment 2 2016-03-29 18:29:54 PDT
Comment on attachment 275146 [details] Patch r=me
Geoffrey Garen
Comment 3 2016-03-29 19:22:43 PDT
Committed r198821: <http://trac.webkit.org/changeset/198821>
Gavin Barraclough
Comment 4 2016-03-29 19:29:00 PDT
Comment on attachment 275146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275146&action=review > Source/bmalloc/bmalloc/VMAllocate.h:51 > + return sysconf(_SC_PAGESIZE); Would it be worth caching the result here? - or are all interesting uses via Heap?
Gavin Barraclough
Comment 5 2016-03-29 19:29:32 PDT
r=me & Ellie Barraclough too.
Geoffrey Garen
Comment 6 2016-03-29 19:33:44 PDT
> > Source/bmalloc/bmalloc/VMAllocate.h:51 > > + return sysconf(_SC_PAGESIZE); > > Would it be worth caching the result here? - or are all interesting uses via > Heap? Hmmm... At first I didn't want to because threads. But I guess we can assume that writing a size_t is atomic.
Geoffrey Garen
Comment 7 2016-03-29 19:34:05 PDT
> r=me & Ellie Barraclough too. \0/
Note You need to log in before you can comment on or make changes to this bug.