| Summary: | Implement logging for RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Component: | bmalloc | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ggaren, krollin, saam | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 155409 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
David Kilzer (:ddkilzer)
2016-03-29 16:06:00 PDT
Created attachment 275273 [details]
Patch v1
Attachment 275273 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/BAssert.h:79: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275273 [details]
Patch v1
r=me
I guess this is OK.
Do we need this? It looks like we'll only use it for soft linking failures. Are we suffering from soft linking failures we need to diagnose?
A problem with heavy and complex ASSERT macros is that they destroy the CPU context at the point of assertion failure, so they make crash reports much less useful.
So, I guess I can say OK to RELEASE_BASSERT_WITH_MESSAGE for soft linking because it's only a small part of the project, but this is an idiom I'd like to avoid using very much.
Created attachment 275505 [details]
Patch v2
(In reply to comment #3) > Comment on attachment 275273 [details] > Patch v1 > > r=me > > I guess this is OK. > > Do we need this? It looks like we'll only use it for soft linking failures. > Are we suffering from soft linking failures we need to diagnose? > > A problem with heavy and complex ASSERT macros is that they destroy the CPU > context at the point of assertion failure, so they make crash reports much > less useful. > > So, I guess I can say OK to RELEASE_BASSERT_WITH_MESSAGE for soft linking > because it's only a small part of the project, but this is an idiom I'd like > to avoid using very much. Patch v2 only does the extra logging in Debug builds, so Release builds won't destroy CPU context. Attachment 275505 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/BAssert.h:82: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275505 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=275505&action=review r=me > Source/bmalloc/bmalloc/BAssert.h:72 > +#define BMALLOC_LOGGING_PREFIX "#BM: " Might as well throw in the full "bmalloc:" here if we can. Comment on attachment 275505 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=275505&action=review >> Source/bmalloc/bmalloc/BAssert.h:72 >> +#define BMALLOC_LOGGING_PREFIX "#BM: " > > Might as well throw in the full "bmalloc:" here if we can. I'll change this. I was mimicking what was done in Source/WTF/wtf/Assertions.h: #define WTF_LOGGING_PREFIX "#WK: " Committed r201969: <http://trac.webkit.org/changeset/201969> |