Summary: | Add WebKit Nightly Archives, WebKit Nightly Start, and Downloads page | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Davis <jond> | ||||||
Component: | WebKit Website | Assignee: | Jon Davis <jond> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jond, timothy | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jon Davis
2016-03-29 14:22:46 PDT
Created attachment 275137 [details]
Patch
Comment on attachment 275137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275137&action=review > Websites/webkit.org/wp-content/plugins/sync-nightly-builds.php:36 > + add_action( 'update_webkit_nightly_builds', function () { Stray extra space. > Websites/webkit.org/wp-content/plugins/sync-nightly-builds.php:144 > + > + Extra newline. > Websites/webkit.org/wp-content/plugins/sync-nightly-builds.php:160 > + return ( $build >= $start && $build <= $end ); No need for the (). > Websites/webkit.org/wp-content/plugins/sync-nightly-builds.php:170 > + return ( $target > $older && $target < $newer ); Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:68 > + We usually don't add these empty lines. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:73 > + Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:77 > + Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:81 > + Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:85 > + Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:89 > + Ditto. > Websites/webkit.org/wp-content/themes/webkit/downloads.php:99 > + > + Double newline. > Websites/webkit.org/wp-content/themes/webkit/functions.php:55 > + return (string)json_encode($builds); Why is the type cast needed? > Websites/webkit.org/wp-content/themes/webkit/functions.php:151 > +// remove_filter('the_content', 'wpautop'); Did you mean to do this? Keep or delete. > Websites/webkit.org/wp-content/themes/webkit/images/spinner.svg:3 > + <rect x='46.5' y='40' width='7' height='20' rx='3.5' ry='3.5' fill='black' transform='rotate(0 50 50) translate(0 -30)'> Use double quotes for everything. > Websites/webkit.org/wp-content/themes/webkit/images/spinner.svg:4 > + <animate attributeName='opacity' from='1' to='0' dur='1s' begin='0s' repeatCount='indefinite'/> Clever. Created attachment 275149 [details]
Patch
Comment on attachment 275149 [details] Patch Clearing flags on attachment: 275149 Committed r198816: <http://trac.webkit.org/changeset/198816> All reviewed patches have been landed. Closing bug. |