Bug 155985

Summary: Fix typos in our error messages and remove some trailing periods
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, joepeck, keith_miller, mark.lam, msaboff, oliver, rniwa, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews100 for mac-yosemite
none
patch for landing none

Saam Barati
Reported 2016-03-29 13:18:18 PDT
...
Attachments
patch (76.03 KB, patch)
2016-03-29 14:18 PDT, Saam Barati 		mark.lam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.06 MB, application/zip)
2016-03-29 14:58 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews100 for mac-yosemite (773.20 KB, application/zip)
2016-03-29 15:03 PDT, Build Bot 		no flags
Details
patch for landing (78.13 KB, patch)
2016-03-29 15:07 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-29 14:18:43 PDT
Created attachment 275130 [details] patch
Mark Lam
Comment 2 2016-03-29 14:21:50 PDT
Comment on attachment 275130 [details] patch r=me
Sukolsak Sakshuwong
Comment 3 2016-03-29 14:39:29 PDT
Comment on attachment 275130 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275130&action=review > Source/JavaScriptCore/runtime/ProxyObject.cpp:886 > + createListFromArrayLike(exec, arrayLikeObject, dontThrowAnExceptionTypeFilter, ASCIILiteral("Proxy handler's 'ownKeys' method must return a array-like object containing only Strings and Symbols"), addPropName); "a array-like" -> "an array-like"
Build Bot
Comment 4 2016-03-29 14:58:34 PDT
Comment on attachment 275130 [details] patch Attachment 275130 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1065291 New failing tests: js/string-includes.html
Build Bot
Comment 5 2016-03-29 14:58:38 PDT
Created attachment 275138 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Saam Barati
Comment 6 2016-03-29 14:59:30 PDT
(In reply to comment #3) > Comment on attachment 275130 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=275130&action=review > > > Source/JavaScriptCore/runtime/ProxyObject.cpp:886 > > + createListFromArrayLike(exec, arrayLikeObject, dontThrowAnExceptionTypeFilter, ASCIILiteral("Proxy handler's 'ownKeys' method must return a array-like object containing only Strings and Symbols"), addPropName); > > "a array-like" -> "an array-like" Thanks. Will change
Build Bot
Comment 7 2016-03-29 15:03:30 PDT
Comment on attachment 275130 [details] patch Attachment 275130 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1065339 New failing tests: js/string-includes.html
Build Bot
Comment 8 2016-03-29 15:03:33 PDT
Created attachment 275140 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Saam Barati
Comment 9 2016-03-29 15:07:24 PDT
Created attachment 275141 [details] patch for landing
WebKit Commit Bot
Comment 10 2016-03-29 17:24:16 PDT
Comment on attachment 275141 [details] patch for landing Clearing flags on attachment: 275141 Committed r198813: <http://trac.webkit.org/changeset/198813>
WebKit Commit Bot
Comment 11 2016-03-29 17:24:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.