Bug 155973

Summary: REGRESSION (r196813): Missing plug-in placeholder is missing
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2016-03-29 10:05:40 PDT
1, launch Safari (not having installed Flash yet) 2, go to www.badgerbadgerbadger.com (auto-playing looping Flash animation) "Missing Plug-in" button is missing.
Attachments
Patch (2.16 KB, patch)
2016-03-29 10:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-03-29 10:06:07 PDT
rdar://problem/25068392
alan
Comment 2 2016-03-29 10:21:36 PDT
Created attachment 275102 [details] Patch
Andy Estes
Comment 3 2016-03-29 10:23:36 PDT
Comment on attachment 275102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275102&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION (r196813): Missing plug-in placeholder is missing :|
WebKit Commit Bot
Comment 4 2016-03-29 11:33:34 PDT
Comment on attachment 275102 [details] Patch Clearing flags on attachment: 275102 Committed r198785: <http://trac.webkit.org/changeset/198785>
WebKit Commit Bot
Comment 5 2016-03-29 11:33:38 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 6 2016-03-29 11:57:19 PDT
Please add a expected-to-be-different reftest. You can do this by naming the expected file mytest-expected-mismatch.html
alan
Comment 7 2016-03-29 12:09:09 PDT
(In reply to comment #6) > Please add a expected-to-be-different reftest. You can do this by naming the > expected file mytest-expected-mismatch.html I am not much of a fan of -mismatch, but I guess it's better than no test.
alan
Comment 8 2016-03-31 09:49:34 PDT
LayoutTests/plugins/missing-plugin-placeholder.html Committed r198898: <http://trac.webkit.org/changeset/198898>
Note You need to log in before you can comment on or make changes to this bug.