Bug 155973

Summary: REGRESSION (r196813): Missing plug-in placeholder is missing
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2016-03-29 10:05:40 PDT
1, launch Safari (not having installed Flash yet)
2, go to www.badgerbadgerbadger.com (auto-playing looping Flash animation)
"Missing Plug-in" button is missing.
Comment 1 zalan 2016-03-29 10:06:07 PDT
rdar://problem/25068392
Comment 2 zalan 2016-03-29 10:21:36 PDT
Created attachment 275102 [details]
Patch
Comment 3 Andy Estes 2016-03-29 10:23:36 PDT
Comment on attachment 275102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275102&action=review

> Source/WebCore/ChangeLog:3
> +        REGRESSION (r196813): Missing plug-in placeholder is missing

:|
Comment 4 WebKit Commit Bot 2016-03-29 11:33:34 PDT
Comment on attachment 275102 [details]
Patch

Clearing flags on attachment: 275102

Committed r198785: <http://trac.webkit.org/changeset/198785>
Comment 5 WebKit Commit Bot 2016-03-29 11:33:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Myles C. Maxfield 2016-03-29 11:57:19 PDT
Please add a expected-to-be-different reftest. You can do this by naming the expected file mytest-expected-mismatch.html
Comment 7 zalan 2016-03-29 12:09:09 PDT
(In reply to comment #6)
> Please add a expected-to-be-different reftest. You can do this by naming the
> expected file mytest-expected-mismatch.html
I am not much of a fan of -mismatch, but I guess it's better than no test.
Comment 8 zalan 2016-03-31 09:49:34 PDT
LayoutTests/plugins/missing-plugin-placeholder.html

Committed r198898: <http://trac.webkit.org/changeset/198898>