Bug 155960

Summary: Allow builtin JS functions to be intrinsics
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
patch mark.lam: review+

Saam Barati
Reported 2016-03-28 18:11:01 PDT
...
Attachments
WIP (21.74 KB, patch)
2016-03-28 18:11 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (22.13 KB, patch)
2016-03-28 18:43 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (22.18 KB, patch)
2016-03-29 10:59 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (22.15 KB, patch)
2016-03-29 11:20 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (25.94 KB, patch)
2016-03-29 13:16 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-28 18:11:38 PDT
Created attachment 275073 [details] WIP
WebKit Commit Bot
Comment 2 2016-03-28 18:13:45 PDT
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
WebKit Commit Bot
Comment 3 2016-03-28 18:14:00 PDT
Attachment 275073 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 4 2016-03-28 18:43:17 PDT
Created attachment 275074 [details] WIP
WebKit Commit Bot
Comment 5 2016-03-28 18:44:53 PDT
Attachment 275074 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 6 2016-03-29 10:59:00 PDT
Created attachment 275108 [details] WIP
WebKit Commit Bot
Comment 7 2016-03-29 10:59:54 PDT
Attachment 275108 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 8 2016-03-29 11:20:36 PDT
Created attachment 275112 [details] WIP
WebKit Commit Bot
Comment 9 2016-03-29 11:21:52 PDT
Attachment 275112 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 10 2016-03-29 13:16:09 PDT
Created attachment 275123 [details] patch
WebKit Commit Bot
Comment 11 2016-03-29 13:17:38 PDT
Attachment 275123 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5] ERROR: Source/JavaScriptCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 5 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 12 2016-03-29 13:37:18 PDT
Comment on attachment 275123 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275123&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + Please delete blank space here.
Saam Barati
Comment 13 2016-03-29 14:04:48 PDT
landed in: http://trac.webkit.org/changeset/198798
Note You need to log in before you can comment on or make changes to this bug.