| Summary: | Allow builtin JS functions to be intrinsics | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bburg, benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Saam Barati
2016-03-28 18:11:01 PDT
Created attachment 275073 [details]
WIP
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) Attachment 275073 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 275074 [details]
WIP
Attachment 275074 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 275108 [details]
WIP
Attachment 275108 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 275112 [details]
WIP
Attachment 275112 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 275123 [details]
patch
Attachment 275123 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1586: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:133: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139: multiple statements on one line (semicolon) [pep8/E702] [5]
ERROR: Source/JavaScriptCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 5 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275123 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=275123&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + Please delete blank space here. landed in: http://trac.webkit.org/changeset/198798 |