Bug 15595 – marker property doesn't show up correctly as "shorthand" in inspector

• Component: SVG
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

marker property doesn't show up correctly as "shorthand" in inspector

SVG marker CSS property is parsed with some custom code in SVGCSSParser which seems to confuse the "shorthand" accessors on CSSComputedStyle.  The inspector seems to display them as 3 properties instead of as one with a disclosure triangle.  Additionally, it highlights "marker-start" as a real property in the inline style declaration, and fades marker-mid and marker-end as though they were implicit.

I'm not sure if to fix this (minor) bug we'd need to fix the inspector or the SVG CSS parsing code.  But probably best to fix the parsing code.

[Eric Seidel (no email)]

Created attachment 16768 [details]
example file with marker (use inspector to see bug)

[Rob Buis]

Created attachment 20201 [details]
First attempt

This patch makes the marker property show up much better in the Inspector.
There is some confusion on the exact marker property syntax, see:

http://lists.w3.org/Archives/Public/www-svg/2008Mar/0093.html

I think that needs to be clarified before this can go in.
As for tests, AFAIK it is impossible to test how it looks in the Inspector. However I guess it makes sense to test getPropertyValue("marker") on
the CSSStyleDeclaration.
In the meantime, the code can be reviewed I guess.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 20201 [details]
First attempt

This looks good to me. But Hyatt should confirm.

[Eric Seidel (no email)]

Adding our resident ShorthandScope expert to confirm this (simple) patch is correct.

[Rob Buis]

Created attachment 20217 [details]
Now with testcase

This one add a testcase for the changed getPropertyValue behaviour regarding marker. We now return the same value as Opera and FF do.
Cheers,

Rob.

[Darin Adler]

Comment on attachment 20217 [details]
Now with testcase

r=me

[Rob Buis]

Landed in r31453.