Bug 155920

Summary: Misc. JavaScriptCore built-ins cleanups
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
sam: review+, joepeck: commit-queue-
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-03-25 22:26:39 PDT
* SUMMARY Misc. JavaScriptCore built-ins cleanups. Some weird styles and a typo in an error message.
Attachments
[PATCH] Proposed Fix (3.94 KB, patch)
2016-03-25 22:27 PDT, Joseph Pecoraro 		sam: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (4.98 KB, patch)
2016-03-25 22:50 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-03-25 22:27:57 PDT
Created attachment 274975 [details] [PATCH] Proposed Fix
Sam Weinig
Comment 2 2016-03-25 22:30:32 PDT
Comment on attachment 274975 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=274975&action=review > Source/JavaScriptCore/builtins/TypedArrayConstructor.js:37 > + throw new @TypeError("TypedArray.of requires its this argument to subclass a TypedArray constructor"); Can we test this?
Joseph Pecoraro
Comment 3 2016-03-25 22:50:25 PDT
Created attachment 274978 [details] [PATCH] Proposed Fix Now with a test.
Mark Lam
Comment 4 2016-03-25 22:53:15 PDT
Comment on attachment 274978 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2016-03-25 23:51:13 PDT
Comment on attachment 274978 [details] [PATCH] Proposed Fix Clearing flags on attachment: 274978 Committed r198713: <http://trac.webkit.org/changeset/198713>
WebKit Commit Bot
Comment 6 2016-03-25 23:51:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.