Bug 155907

Summary: AX: VoiceOver not announcing the right header information for table on iOS
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
initial patch
none
patch none

Description Nan Wang 2016-03-25 16:41:38 PDT 
1. Launch Safari and VoiceOver
2. Go to http://www.w3.org/WAI/tutorials/tables/caption-summary/
3. Swipe right until reach example of Approach 3
4. Listen to the announcement of each cell of this table

For the “Studio” cell, it’s announced as “1 bedroom, Studio”,
For the first column, “1 bedroom” is announced as “2 bedroom, 1 bedroom”.
It seemed those header informations were messed up by the empty cell at the beginning.
Comment 1 Nan Wang 2016-03-25 16:41:59 PDT 
<rdar://problem/22668467>
Comment 2 Nan Wang 2016-03-25 16:59:01 PDT 
Created attachment 274956 [details]
initial patch

My simulator keeps crashing. Will try to add a layout test later.
Comment 3 chris fleizach 2016-03-27 11:19:45 PDT 
Comment on attachment 274956 [details]
initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274956&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1067
> +        if (rowRangeIndex >= rowHeaderRange.first && rowRangeIndex <= rowHeaderRange.first + rowHeaderRange.second - 1) {

this should be equivalent right?

rowRangeIndex < rowHeaderRange.first + rowHeaderRange.second

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1069
> +            if (wrapper)

if (AccessibilityObjectWrapper* wrapper = rowHeader->wrapper())
   [headers add...
Comment 4 Nan Wang 2016-03-29 17:31:43 PDT 
Created attachment 275158 [details]
patch

Got the simulator test working
Comment 5 WebKit Commit Bot 2016-03-29 19:02:46 PDT 
Comment on attachment 275158 [details]
patch

Clearing flags on attachment: 275158

Committed r198819: <http://trac.webkit.org/changeset/198819>
Comment 6 WebKit Commit Bot 2016-03-29 19:02:50 PDT 
All reviewed patches have been landed.  Closing bug.