Bug 155885

Summary: RenderImage::repaintOrMarkForLayout fails when the renderer is detached.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cdumez, cmarcelo, commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, mcatanzaro, simon.fraser, tpopela, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155109
Attachments:
Description Flags
backtrace
none
Patch
none
Patch
zalan: commit-queue-
Patch none

Description zalan 2016-03-25 08:56:19 PDT
Created attachment 274908 [details]
backtrace

see stacktrace.
Comment 1 Radar WebKit Bug Importer 2016-03-25 08:58:59 PDT
<rdar://problem/25359164>
Comment 2 zalan 2016-03-25 09:45:37 PDT
related to bug 155109
Comment 3 zalan 2016-03-25 15:06:47 PDT
Created attachment 274945 [details]
Patch
Comment 4 Simon Fraser (smfr) 2016-03-25 15:14:59 PDT
Comment on attachment 274945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274945&action=review

> Source/WebCore/rendering/RenderObject.cpp:716
>      if (!is<RenderBlock>(parent))

This should just be a null check.
Comment 5 zalan 2016-03-25 15:38:24 PDT
Created attachment 274948 [details]
Patch
Comment 6 zalan 2016-03-25 15:41:55 PDT
Created attachment 274949 [details]
Patch
Comment 7 WebKit Commit Bot 2016-03-25 16:45:13 PDT
Comment on attachment 274949 [details]
Patch

Clearing flags on attachment: 274949

Committed r198701: <http://trac.webkit.org/changeset/198701>
Comment 8 WebKit Commit Bot 2016-03-25 16:45:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Michael Catanzaro 2016-04-06 18:12:18 PDT
FYI I am backporting this to our 2.12.0 package in Fedora. We haven't received many crash reports because we don't have 2.12.0 in any stable release yet, but I've gotten several complaints on Bugzilla and IRC.

(Thanks for fixing it so quickly, Zalan.)
Comment 10 Michael Catanzaro 2016-04-06 18:13:28 PDT
Notable complaint is that this crash occurs on Google shortly after searching for anything (although I wasn't able to reproduce that myself).