Bug 155873

Summary: RegExp constructor should use Symbol.match and other properties
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 156299    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2016-03-24 22:34:15 PDT
RegExp constructor should use Symbol.match and other properties
Attachments
Patch (11.34 KB, patch)
2016-03-25 09:42 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.34 KB, patch)
2016-04-04 16:59 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.64 KB, patch)
2016-04-06 10:26 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-03-25 09:42:20 PDT
Created attachment 274911 [details] Patch
Michael Saboff
Comment 2 2016-03-25 10:59:59 PDT
Comment on attachment 274911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274911&action=review r=me > Source/JavaScriptCore/runtime/RegExpConstructor.cpp:281 > // ECMA 15.10.4 Please update the spec reference.
Keith Miller
Comment 3 2016-04-04 16:59:21 PDT
Created attachment 275594 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-04-04 22:16:05 PDT
Comment on attachment 275594 [details] Patch for landing Rejecting attachment 275594 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: : *** Waiting for unfinished jobs.... make: *** [Bytecodes.h] Error 1 perl JavaScriptCore/Scripts/xxd.pl InjectedScriptSource_js ./InjectedScriptSource.min.js InjectedScriptSource.h rm -f InjectedScriptSource.min.js Command /bin/sh failed with exit code 2 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution Generate\ Derived\ Sources /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/Derived\ Sources.build/Script-65FB3F6509D11E9100F49DEB.sh (1 failure) Full output: http://webkit-queues.webkit.org/results/1101397
Keith Miller
Comment 5 2016-04-06 10:26:42 PDT
Created attachment 275780 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-04-06 11:26:14 PDT
Comment on attachment 275780 [details] Patch for landing Clearing flags on attachment: 275780 Committed r199106: <http://trac.webkit.org/changeset/199106>
WebKit Commit Bot
Comment 7 2016-04-06 11:26:17 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2016-04-06 11:40:56 PDT
Re-opened since this is blocked by bug 156299
Keith Miller
Comment 9 2016-04-06 11:48:19 PDT
Requested rollout on the wrong patch.
Note You need to log in before you can comment on or make changes to this bug.