Bug 15583

Summary: Sunspider needs better argument handling
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the patch
darin: review+
even better patch darin: review+

Eric Seidel (no email)
Reported 2007-10-20 18:31:53 PDT
Sunspider needs better argument handling The attached patch does just that! :)
Attachments
the patch (11.03 KB, patch)
2007-10-20 18:32 PDT, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
even better patch (18.70 KB, patch)
2007-10-20 19:26 PDT, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-10-20 18:32:19 PDT
Created attachment 16750 [details] the patch
Darin Adler
Comment 2 2007-10-20 18:53:39 PDT
Comment on attachment 16750 [details] the patch r=me
Eric Seidel (no email)
Comment 3 2007-10-20 19:26:51 PDT
Created attachment 16753 [details] even better patch Mark Rowe pointed out that we were duplicating the testkjs building code, so I fixed that. I also cleaned up some other (broken) building code in other files.
Darin Adler
Comment 4 2007-10-20 19:44:46 PDT
Comment on attachment 16753 [details] even better patch All looks good. r=me
Eric Seidel (no email)
Comment 5 2007-10-20 19:55:38 PDT
r26838
Note You need to log in before you can comment on or make changes to this bug.