Bug 155817

Summary: CSP: Simplify logic for checking policies
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, commit-queue, mkwst, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2016-03-23 16:00:18 PDT
Currently we have various static template functions in ContentSecurityPolicy.cpp to check if a resource request for a particular directive violates any of the CSPs that were delivered with the document. These functions are identical up to the function F they invoke and the arguments they take and pass to F. We should look to consolidate these function into a single function that has a similar prototype as std::invoke() to remove duplication and centralize the semantics for determining a directive violation against some CSP policy.
Attachments
Patch (24.96 KB, patch)
2016-03-23 16:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-23 16:01:39 PDT
<rdar://problem/25326546>
Daniel Bates
Comment 2 2016-03-23 16:05:33 PDT
Created attachment 274789 [details] Patch
Daniel Bates
Comment 3 2016-03-23 19:41:27 PDT
Comment on attachment 274789 [details] Patch Clearing flags on attachment: 274789 Committed r198613: <http://trac.webkit.org/changeset/198613>
Daniel Bates
Comment 4 2016-03-23 19:41:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.