Bug 155809

Summary: Web Inspector: Ensure maximum accuracy while profiling
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ggaren, graouts, joepeck, mattbaker, nvasilyev, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 152193    
Bug Blocks:    
Attachments:
Description Flags
patch
none
[PATCH] Proposed Fix
none
[IMAGE] Debugger Sidebar during recording none

Description Joseph Pecoraro 2016-03-23 15:06:12 PDT
* SUMMARY
Script & Events should have a High Fidelity Profiling mode.

In this mode we would disable things that can affect performance while the inspector is open, allowing developers to profile the absolute maximum performance JavaScript while the Inspector is open.

  - disable breakpoints (see bug 152193) to disable debugger deoptimizations
  - disallow or warn if used with other expensive timelines (Heap Allocations)
  - maybe disable some domains (CSS / DOM) to avoid updates during recording?
  - maybe reduce the sample interval to get more samples?

* NOTES
- When starting / stopping recording, save & disable breakpoints then restore breakpoints setting to whatever it was
- While recording, prevent the inspector from enabling breakpoints
Comment 1 Radar WebKit Bug Importer 2016-03-23 15:06:59 PDT
<rdar://problem/25325035>
Comment 2 Saam Barati 2016-03-23 17:59:22 PDT
Created attachment 274803 [details]
patch
Comment 3 Saam Barati 2016-03-23 17:59:51 PDT
Comment on attachment 274803 [details]
patch

oops wrong bug
Comment 4 Joseph Pecoraro 2016-03-28 18:59:30 PDT
Retitling. Instead of having an opt-in high fidelity profiling mode we should just always do the best we can when timeline recording. That means automatically disabling breakpoints and re-enabling them (if needed) when doing a timeline recording.
Comment 5 Joseph Pecoraro 2016-03-28 19:11:52 PDT
Created attachment 275075 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2016-03-28 19:21:19 PDT
Created attachment 275076 [details]
[IMAGE] Debugger Sidebar during recording
Comment 7 WebKit Commit Bot 2016-03-28 20:28:10 PDT
Comment on attachment 275075 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 275075

Committed r198774: <http://trac.webkit.org/changeset/198774>
Comment 8 WebKit Commit Bot 2016-03-28 20:28:14 PDT
All reviewed patches have been landed.  Closing bug.