Summary: | Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2016-03-23 11:50:20 PDT
Created attachment 274765 [details]
Patch
Comment on attachment 274765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274765&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:378 > + if (m_handle) > + m_handle->continueCanAuthenticateAgainstProtectionSpace(result); We use m_handle when using NetworkSession for blobs, and m_task for non-blob network loads. Comment on attachment 274765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274765&action=review > Source/WebKit2/NetworkProcess/NetworkLoad.cpp:351 > ASSERT(m_challengeCompletionHandler); > auto completionHandler = WTFMove(m_challengeCompletionHandler); > + if (!completionHandler) > + return; > + Please find the path that gets you here. ASSERT(x) if (!x) return; is not good WebKit happiness. >> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:378 >> + m_handle->continueCanAuthenticateAgainstProtectionSpace(result); > > We use m_handle when using NetworkSession for blobs, and m_task for non-blob network loads. This part seems fine. |