Bug 155796

Summary: Ninja build path is incorrect when git branch name is appended to WebKitBuild
Product: WebKit Reporter: Bill Ming <mbbill>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Bill Ming
Reported 2016-03-23 09:54:59 PDT
Executing ./Tools/Scripts/webkit-patch setup-git-clone and when it comes to the last step: "Do you want to append the git branch name to every build? (e.g. WebKitBuild/mybranch/; y/n)" Answer yes. run ./Tools/Scripts/build-webkit --wincairo --release (I'm testing on windows) Build will fail because ninja is still given a path without branch name.
Attachments
Patch (1.20 MB, patch)
2016-03-23 10:04 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2016-03-23 10:11 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
Patch (1.15 KB, patch)
2016-03-23 18:58 PDT, Bill Ming 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bill Ming
Comment 1 2016-03-23 10:04:05 PDT
Created attachment 274752 [details] Patch
Bill Ming
Comment 2 2016-03-23 10:11:07 PDT
Created attachment 274753 [details] Patch
Alex Christensen
Comment 3 2016-03-23 13:44:04 PDT
Comment on attachment 274753 [details] Patch I'm glad to hear from people building with different configurations! Would it work to use determineBaseProductDir(); and chdir $baseProductDir ? That would probably be cleaner, so we don't have to add the same git checks in two different places.
Bill Ming
Comment 4 2016-03-23 18:58:29 PDT
Created attachment 274810 [details] Patch
Bill Ming
Comment 5 2016-03-23 19:01:05 PDT
(In reply to comment #3) > Comment on attachment 274753 [details] > Patch > > I'm glad to hear from people building with different configurations! > > Would it work to use determineBaseProductDir(); and chdir $baseProductDir ? > That would probably be cleaner, so we don't have to add the same git checks > in two different places. Thanks for the review. The patch is updated.
WebKit Commit Bot
Comment 6 2016-03-23 22:13:37 PDT
Comment on attachment 274810 [details] Patch Clearing flags on attachment: 274810 Committed r198616: <http://trac.webkit.org/changeset/198616>
WebKit Commit Bot
Comment 7 2016-03-23 22:13:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.