Bug 155775

Summary: Use references instead of pointers for absolute positioning code
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, jfernandez, jonlee, kondapallykalyan, rego, simon.fraser, svillar, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2016-03-22 16:37:05 PDT
Use references instead of pointers for absolute positioning code
Attachments
Patch (69.13 KB, patch)
2016-03-22 16:38 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-22 16:38:24 PDT
Created attachment 274699 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-03-22 16:55:18 PDT
Comment on attachment 274699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274699&action=review > Source/WebCore/rendering/RenderTable.cpp:275 > - RenderBlock* cb = containingBlock(); > + RenderBlock& cb = *containingBlock(); Nope. containingBlock() can return nullptr.
Myles C. Maxfield
Comment 3 2016-03-22 17:00:46 PDT
(In reply to comment #2) > Comment on attachment 274699 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274699&action=review > > > Source/WebCore/rendering/RenderTable.cpp:275 > > - RenderBlock* cb = containingBlock(); > > + RenderBlock& cb = *containingBlock(); > > Nope. containingBlock() can return nullptr. It can, but we immediately dereference it. Therefore, it must not return nullptr here. Every change in this patch is of this form.
WebKit Commit Bot
Comment 4 2016-03-22 17:58:36 PDT
Comment on attachment 274699 [details] Patch Clearing flags on attachment: 274699 Committed r198568: <http://trac.webkit.org/changeset/198568>
WebKit Commit Bot
Comment 5 2016-03-22 17:58:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.