Bug 155771 – Add machine-readable results for JSC stress tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Srinivasan Vijayaraghavan]

Add machine-readable results for JSC stress tests

[Srinivasan Vijayaraghavan]

Created attachment 274690 [details]
Patch

[Dean Johnson]

Comment on attachment 274690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274690&action=review

LGTM otherwise!

> Tools/Scripts/run-javascriptcore-tests:71
> +my $jsonFileName = "jsc.json";

Can we come up with a better name for this? Maybe "jsc_test_failures.json"

> Tools/Scripts/run-javascriptcore-tests:334
> +        my $json_string = encode_json \%json_data;

This should probably be jsonString, so we follow the same naming conventions as other variables in the file.

[Srinivasan Vijayaraghavan]

(In reply to comment #2)
> Comment on attachment 274690 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274690&action=review
> 
> LGTM otherwise!
> 
> > Tools/Scripts/run-javascriptcore-tests:71
> > +my $jsonFileName = "jsc.json";
> 
> Can we come up with a better name for this? Maybe "jsc_test_failures.json"

Yup, we could do that. Alternatively, what do you think of having the filename being a command-line parameter? So the option could be something like --json-output="<filename>". This would require taking care of relative paths (there are functions in the webkitdirs.pm module which might help with that).

> 
> > Tools/Scripts/run-javascriptcore-tests:334
> > +        my $json_string = encode_json \%json_data;
> 
> This should probably be jsonString, so we follow the same naming conventions
> as other variables in the file.
My bad. Thanks!

[Srinivasan Vijayaraghavan]

Created attachment 274698 [details]
Patch

[Srinivasan Vijayaraghavan]

Created attachment 274864 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 274864 [details]
Patch

This patch doesn't have a ChangeLog.

One thing you can do is say in the ChangeLog "Reviewed by Darin Adler and Dean Johnson.", and then only request commit-queue for the new patch.

[Srinivasan Vijayaraghavan]

Created attachment 274869 [details]
Patch

[Srinivasan Vijayaraghavan]

Created attachment 274870 [details]
Patch

[Srinivasan Vijayaraghavan]

Created attachment 275132 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 275132 [details]
Patch

Clearing flags on attachment: 275132

Committed r198807: <http://trac.webkit.org/changeset/198807>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.