Bug 155771

Summary: Add machine-readable results for JSC stress tests
Product: WebKit Reporter: Srinivasan Vijayaraghavan <webkit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dburkart, msaboff, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Srinivasan Vijayaraghavan
Reported 2016-03-22 15:12:53 PDT
Add machine-readable results for JSC stress tests
Attachments
Patch (2.89 KB, patch)
2016-03-22 15:20 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2016-03-22 16:35 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2016-03-24 16:23 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2016-03-24 17:57 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (3.94 KB, patch)
2016-03-24 18:04 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Patch (4.32 KB, patch)
2016-03-29 14:23 PDT, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1 2016-03-22 15:20:59 PDT
Created attachment 274690 [details] Patch
Dean Johnson
Comment 2 2016-03-22 16:08:09 PDT
Comment on attachment 274690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274690&action=review LGTM otherwise! > Tools/Scripts/run-javascriptcore-tests:71 > +my $jsonFileName = "jsc.json"; Can we come up with a better name for this? Maybe "jsc_test_failures.json" > Tools/Scripts/run-javascriptcore-tests:334 > + my $json_string = encode_json \%json_data; This should probably be jsonString, so we follow the same naming conventions as other variables in the file.
Srinivasan Vijayaraghavan
Comment 3 2016-03-22 16:24:07 PDT
(In reply to comment #2) > Comment on attachment 274690 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274690&action=review > > LGTM otherwise! > > > Tools/Scripts/run-javascriptcore-tests:71 > > +my $jsonFileName = "jsc.json"; > > Can we come up with a better name for this? Maybe "jsc_test_failures.json" Yup, we could do that. Alternatively, what do you think of having the filename being a command-line parameter? So the option could be something like --json-output="<filename>". This would require taking care of relative paths (there are functions in the webkitdirs.pm module which might help with that). > > > Tools/Scripts/run-javascriptcore-tests:334 > > + my $json_string = encode_json \%json_data; > > This should probably be jsonString, so we follow the same naming conventions > as other variables in the file. My bad. Thanks!
Srinivasan Vijayaraghavan
Comment 4 2016-03-22 16:35:46 PDT
Created attachment 274698 [details] Patch
Srinivasan Vijayaraghavan
Comment 5 2016-03-24 16:23:35 PDT
Created attachment 274864 [details] Patch
Alexey Proskuryakov
Comment 6 2016-03-24 17:41:29 PDT
Comment on attachment 274864 [details] Patch This patch doesn't have a ChangeLog. One thing you can do is say in the ChangeLog "Reviewed by Darin Adler and Dean Johnson.", and then only request commit-queue for the new patch.
Srinivasan Vijayaraghavan
Comment 7 2016-03-24 17:57:08 PDT
Created attachment 274869 [details] Patch
Srinivasan Vijayaraghavan
Comment 8 2016-03-24 18:04:12 PDT
Created attachment 274870 [details] Patch
Srinivasan Vijayaraghavan
Comment 9 2016-03-29 14:23:09 PDT
Created attachment 275132 [details] Patch
WebKit Commit Bot
Comment 10 2016-03-29 15:23:42 PDT
Comment on attachment 275132 [details] Patch Clearing flags on attachment: 275132 Committed r198807: <http://trac.webkit.org/changeset/198807>
WebKit Commit Bot
Comment 11 2016-03-29 15:23:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.