Bug 155731 – Web Inspector: New icon for Heap Allocations timeline

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Created attachment 274618 [details]
[Image] Timelines tree icons

* SUMMARY
New icon for Heap Allocations timeline. Same color scheme as Memory timeline, different graphic.

[Radar WebKit Bug Importer]

<rdar://problem/25275494>

[Matt Baker]

Created attachment 274620 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 274620 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274620&action=review

r=me!

> Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg:4
> +    <circle id="Oval" fill="rgb(224, 166, 133)" cx="8" cy="8" r="7.5" stroke="rgb(179, 114, 76)"/>

I think the `id` here can be dropped.

> Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:40
> +.heap-allocations-icon .icon {
> +    content: url(../Images/HeapAllocationsInstrument.svg);
> +}

Please add a fallback for GTK, see the code just below this (line 50-80) covered by bug 153892. Scripts is probably a reasonable fallback for them in the meantime.

body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon {
    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/[e-mail]) 2x);
}

[Timothy Hatcher]

Comment on attachment 274620 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274620&action=review

> Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg:3
> +<svg viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg">

This should be:
<svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">

Which is the order we use for other SVGs and id="root" incase we ever need to use it as a <symbol>.

[Matt Baker]

Created attachment 274630 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 274630 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=274630&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:81
> +body:not(.mac-platform, .windows-platform) .memory-icon .icon {
> +    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/[e-mail]) 2x);
> +}

Heh, thanks. I neglected to add this because EANBLE_RESOURCE_USAGE is not enabled on other ports yet.

[Matt Baker]

(In reply to comment #6)
> Comment on attachment 274630 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274630&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:81
> > +body:not(.mac-platform, .windows-platform) .memory-icon .icon {
> > +    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/[e-mail]) 2x);
> > +}
> 
> Heh, thanks. I neglected to add this because EANBLE_RESOURCE_USAGE is not
> enabled on other ports yet.

I was wondering :)

[WebKit Commit Bot]

Comment on attachment 274630 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 274630

Committed r198511: <http://trac.webkit.org/changeset/198511>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.