Bug 155707

Summary:

[Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR

Product:

WebKit

Reporter:

mitz

Component:

New Bugs

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, buildbot, commit-queue, dino, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, roger_fong, saam

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET	buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR	darin: review+

mitz

Reported 2016-03-20 19:08:16 PDT

<rdar://problem/24980691>

Attachments
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET (34.68 KB, patch) 2016-03-20 19:38 PDT, mitz	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-yosemite (465.17 KB, application/zip) 2016-03-20 20:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (339.79 KB, application/zip) 2016-03-20 20:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (374.25 KB, application/zip) 2016-03-20 20:32 PDT, Build Bot	no flags	Details
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR (32.18 KB, patch) 2016-03-20 20:41 PDT, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2016-03-20 19:38:39 PDT

Created attachment 274558 [details] Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET

WebKit Commit Bot

Comment 2 2016-03-20 19:40:11 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Build Bot

Comment 3 2016-03-20 20:29:31 PDT

Comment on attachment 274558 [details] Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET Attachment 274558 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1013399 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2016-03-20 20:29:34 PDT

Created attachment 274561 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-03-20 20:29:40 PDT

Comment on attachment 274558 [details] Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET Attachment 274558 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1013411 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2016-03-20 20:29:43 PDT

Created attachment 274562 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-03-20 20:32:06 PDT

Comment on attachment 274558 [details] Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET Attachment 274558 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1013412 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-03-20 20:32:09 PDT

Created attachment 274563 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

mitz

Comment 9 2016-03-20 20:41:21 PDT

Created attachment 274567 [details] Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR

mitz

Comment 10 2016-03-20 22:11:55 PDT

Committed <http://trac.webkit.org/r198481>.

Note You need to log in before you can comment on or make changes to this bug.