Bug 155707

Summary: [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
Product: WebKit Reporter: mitz
Component: New BugsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, dino, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, roger_fong, saam
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET
buildbot: commit-queue-
Archive of layout-test-results from ews117 for mac-yosemite
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR darin: review+

Description mitz 2016-03-20 19:08:16 PDT
<rdar://problem/24980691>
Comment 1 mitz 2016-03-20 19:38:39 PDT
Created attachment 274558 [details]
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET
Comment 2 WebKit Commit Bot 2016-03-20 19:40:11 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Build Bot 2016-03-20 20:29:31 PDT
Comment on attachment 274558 [details]
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET

Attachment 274558 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1013399

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2016-03-20 20:29:34 PDT
Created attachment 274561 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-03-20 20:29:40 PDT
Comment on attachment 274558 [details]
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET

Attachment 274558 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1013411

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-03-20 20:29:43 PDT
Created attachment 274562 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-03-20 20:32:06 PDT
Comment on attachment 274558 [details]
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR and DebugRelease definitions of MACOSX_DEPLOYMENT_TARGET

Attachment 274558 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1013412

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-03-20 20:32:09 PDT
Created attachment 274563 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 9 mitz 2016-03-20 20:41:21 PDT
Created attachment 274567 [details]
Update definitions of TARGET_MAC_OS_X_VERSION_MAJOR
Comment 10 mitz 2016-03-20 22:11:55 PDT
Committed <http://trac.webkit.org/r198481>.