Bug 155664

Summary: Consider to cap the size of session history data.
Product: WebKit Reporter: Yongjun Zhang <yongjun_zhang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, kling, mitz, sam
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=289945
Attachments:
Description Flags
Cap the session history data size to 2MB in iOS.
none
Cap the session history data size to 2MB in iOS.
darin: review+
Address review comment before landing. none

Yongjun Zhang
Reported 2016-03-18 14:41:13 PDT
When encode the session history to data blob, we serialize all the history entries in back/forward list. We should consider to limit the size of this data blob.
Attachments
Cap the session history data size to 2MB in iOS. (4.56 KB, patch)
2016-03-18 16:59 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Cap the session history data size to 2MB in iOS. (4.75 KB, patch)
2016-03-18 17:02 PDT, Yongjun Zhang 		darin: review+
DetailsFormatted DiffDiff
Address review comment before landing. (4.77 KB, patch)
2016-03-18 23:16 PDT, Yongjun Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yongjun Zhang
Comment 1 2016-03-18 14:42:22 PDT
<rdar://problem/25064718>
Yongjun Zhang
Comment 2 2016-03-18 16:59:43 PDT
Created attachment 274479 [details] Cap the session history data size to 2MB in iOS.
Yongjun Zhang
Comment 3 2016-03-18 17:02:49 PDT
Created attachment 274480 [details] Cap the session history data size to 2MB in iOS.
Darin Adler
Comment 4 2016-03-18 22:28:19 PDT
Comment on attachment 274480 [details] Cap the session history data size to 2MB in iOS. View in context: https://bugs.webkit.org/attachment.cgi?id=274480&action=review > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:66 > +static const uint32_t maximumSessionStateDataSize = UINT_MAX; I would prefer std::numeric_limits<uint32_t>::max() to UINT_MAX when used here.
Yongjun Zhang
Comment 5 2016-03-18 23:16:31 PDT
Created attachment 274509 [details] Address review comment before landing.
WebKit Commit Bot
Comment 6 2016-03-19 00:17:46 PDT
Comment on attachment 274509 [details] Address review comment before landing. Clearing flags on attachment: 274509 Committed r198468: <http://trac.webkit.org/changeset/198468>
WebKit Commit Bot
Comment 7 2016-03-19 00:17:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.