Bug 155663

Summary:

Add a WebRTC specific compile flag

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, jer.noble, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for the bots.	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Updated patch.	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Updated patch.	none
Another updated patch	buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Another updated patch	none

Eric Carlson

Reported 2016-03-18 14:37:50 PDT

Define a new WebRTC-specific compile flag since Media Streams is a stand-alone feature.

Attachments
Patch for the bots. (78.08 KB, patch) 2016-03-18 14:45 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (955.91 KB, application/zip) 2016-03-18 15:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (876.07 KB, application/zip) 2016-03-18 15:44 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (881.96 KB, application/zip) 2016-03-18 16:02 PDT, Build Bot	no flags	Details
Updated patch. (83.50 KB, patch) 2016-03-18 16:12 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (977.75 KB, application/zip) 2016-03-18 17:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (809.15 KB, application/zip) 2016-03-18 17:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (886.86 KB, application/zip) 2016-03-18 17:22 PDT, Build Bot	no flags	Details
Updated patch. (93.05 KB, patch) 2016-03-19 09:30 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch (93.52 KB, patch) 2016-03-19 10:05 PDT, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (802.74 KB, application/zip) 2016-03-19 11:03 PDT, Build Bot	no flags	Details
Another updated patch (94.50 KB, patch) 2016-03-20 17:29 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2016-03-18 14:45:51 PDT

Created attachment 274454 [details] Patch for the bots.

WebKit Commit Bot

Comment 2 2016-03-18 14:47:39 PDT

Attachment 274454 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2293: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 113 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2016-03-18 15:40:43 PDT

Comment on attachment 274454 [details] Patch for the bots. Attachment 274454 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1001612 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 4 2016-03-18 15:40:45 PDT

Created attachment 274460 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-03-18 15:44:39 PDT

Comment on attachment 274454 [details] Patch for the bots. Attachment 274454 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1001624 New failing tests: fast/mediastream/RTCPeerConnection-overloaded-operations.html fast/mediastream/RTCSessionDescription.html js/dom/global-constructors-attributes.html fast/mediastream/RTCPeerConnection-closed-state.html fast/mediastream/RTCRtpSender-replaceTrack.html fast/mediastream/RTCPeerConnection-add-removeTrack.html fast/mediastream/RTCPeerConnection-overloaded-operations-params.html

Build Bot

Comment 6 2016-03-18 15:44:41 PDT

Created attachment 274462 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-03-18 16:02:11 PDT

Comment on attachment 274454 [details] Patch for the bots. Attachment 274454 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1001628 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 8 2016-03-18 16:02:14 PDT

Created attachment 274466 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Eric Carlson

Comment 9 2016-03-18 16:12:12 PDT

Created attachment 274469 [details] Updated patch.

Build Bot

Comment 10 2016-03-18 17:05:12 PDT

Comment on attachment 274469 [details] Updated patch. Attachment 274469 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1001953 New failing tests: fast/mediastream/RTCPeerConnection-overloaded-operations.html fast/mediastream/RTCSessionDescription.html js/dom/global-constructors-attributes.html fast/mediastream/RTCPeerConnection-closed-state.html fast/mediastream/RTCRtpSender-replaceTrack.html fast/mediastream/RTCPeerConnection-add-removeTrack.html fast/mediastream/RTCPeerConnection-overloaded-operations-params.html

Build Bot

Comment 11 2016-03-18 17:05:15 PDT

Created attachment 274481 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-03-18 17:07:32 PDT

Comment on attachment 274469 [details] Updated patch. Attachment 274469 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1001968 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 13 2016-03-18 17:07:34 PDT

Created attachment 274482 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 14 2016-03-18 17:22:29 PDT

Comment on attachment 274469 [details] Updated patch. Attachment 274469 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1001989 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 15 2016-03-18 17:22:31 PDT

Created attachment 274484 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Eric Carlson

Comment 16 2016-03-19 09:30:40 PDT

Created attachment 274517 [details] Updated patch.

WebKit Commit Bot

Comment 17 2016-03-19 09:32:31 PDT

Attachment 274517 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:2293: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 18 2016-03-19 10:05:34 PDT

Created attachment 274518 [details] Another updated patch

Build Bot

Comment 19 2016-03-19 11:03:47 PDT

Comment on attachment 274518 [details] Another updated patch Attachment 274518 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1006051 New failing tests: fast/mediastream/RTCPeerConnection-overloaded-operations.html fast/mediastream/RTCSessionDescription.html fast/mediastream/RTCPeerConnection-closed-state.html fast/mediastream/RTCRtpSender-replaceTrack.html fast/mediastream/RTCPeerConnection-add-removeTrack.html fast/mediastream/RTCPeerConnection-overloaded-operations-params.html

Build Bot

Comment 20 2016-03-19 11:03:51 PDT

Created attachment 274519 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Eric Carlson

Comment 21 2016-03-20 17:29:43 PDT

Created attachment 274552 [details] Another updated patch

Eric Carlson

Comment 22 2016-03-21 10:11:24 PDT

<rdar://problem/25116653>

WebKit Commit Bot

Comment 23 2016-03-21 10:52:33 PDT

Comment on attachment 274552 [details] Another updated patch Clearing flags on attachment: 274552 Committed r198492: <http://trac.webkit.org/changeset/198492>

WebKit Commit Bot

Comment 24 2016-03-21 10:52:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.