Bug 155630

Summary: [OS X] Scrollbars are sometimes erroneously reported as overlay
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Myles C. Maxfield
Reported 2016-03-18 01:09:52 PDT
Scrollbars are sometimes erroneously reported as overlay
Attachments
Patch (2.94 KB, patch)
2016-03-18 01:30 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-18 01:30:09 PDT
Created attachment 274393 [details] Patch
Darin Adler
Comment 2 2016-03-18 08:54:59 PDT
Comment on attachment 274393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274393&action=review > Source/WebCore/ChangeLog:26 > + An alternative similar approach would be for ScrollbarThemeMac to listen to the > + NSPreferredScrollerStyleDidChangeNotification. Why didn’t you chose that approach? > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:635 > + if (auto* macTheme = macScrollbarTheme()) > + macTheme->usesOverlayScrollbarsChanged(); I’d just call the super-local variable "theme".
Darin Adler
Comment 3 2016-03-18 08:55:09 PDT
No regression test?
Myles C. Maxfield
Comment 4 2016-03-18 14:14:45 PDT
Committed r198444: <http://trac.webkit.org/changeset/198444>
Note You need to log in before you can comment on or make changes to this bug.