Bug 155619 – Update AutoFill button in input fields

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Zach Li]

Update AutoFill button in input fields.

[Zach Li]

rdar://problem/24486939

[Zach Li]

Created attachment 274368 [details]
Patch v1

[Daniel Bates]

Comment on attachment 274368 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=274368&action=review

Wow, much smaller images. I haven't verified these data URLs. I am assuming they are valid.

> Source/WebCore/css/html.css:574
>      -webkit-mask-size: 15px 12px;

Is the size still the same?

> Source/WebCore/css/html.css:575
>      width: 15px;

Ditto?

> Source/WebCore/css/html.css:576
>      height: 12px;

Ditto?

[Zach Li]

(In reply to comment #3)
> Comment on attachment 274368 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274368&action=review
> 
> Wow, much smaller images. I haven't verified these data URLs. I am assuming
> they are valid.

Could you apply the patch and verify the data URLs?

> 
> > Source/WebCore/css/html.css:574
> >      -webkit-mask-size: 15px 12px;
> 
> Is the size still the same?

Actually no. Glad you caught this!

> 
> > Source/WebCore/css/html.css:575
> >      width: 15px;
> 
> Ditto?

Ditto.

> 
> > Source/WebCore/css/html.css:576
> >      height: 12px;
> 
> Ditto?

This is the same.

[Zach Li]

Created attachment 274394 [details]
Patch v2

[Build Bot]

Comment on attachment 274394 [details]
Patch v2

Attachment 274394 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/998362

New failing tests:
fast/forms/auto-fill-button/input-contacts-auto-fill-button.html

[Build Bot]

Created attachment 274401 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Daniel Bates]

Comment on attachment 274394 [details]
Patch v2

As pointed out by the iOS Simulator EWS please update the expected result LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt as needed before landing (or even better remove this expected result if it is identical to LayoutTests/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt).

[Zach Li]

(In reply to comment #8)
> Comment on attachment 274394 [details]
> Patch v2
> 
> As pointed out by the iOS Simulator EWS please update the expected result
> LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/input-
> contacts-auto-fill-button-expected.txt as needed before landing (or even
> better remove this expected result if it is identical to
> LayoutTests/fast/forms/auto-fill-button/input-contacts-auto-fill-button-
> expected.txt).

Because it says "did not pass ios-sim-ews (ios-simulator-wk2)", I was going to update the expected result in LayoutTests/platform/ios-simulator-wk2/fast/forms/auto-fill-button/ instead of LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/, how did you determine it should be "ios-simulator"?

We also have input-contacts-auto-fill-button-expected.txt for other platforms, what is the general practice to get the expected results for other platforms?

Thanks!

[Daniel Bates]

(In reply to comment #9)
> We also have input-contacts-auto-fill-button-expected.txt for other
> platforms, what is the general practice to get the expected results for
> other platforms?
> 

In theory, you would build the other ports with your patch, generate the expected result and include it in your patch before landing. In practice, it is sufficient to land your change, watch the build bots on build.webkit.org for the other platforms and collect their expected results. Then land the collected results in a follow up patch (no review needed).

[Daniel Bates]

(In reply to comment #9)
> Because it says "did not pass ios-sim-ews (ios-simulator-wk2)", I was going
> to update the expected result in
> LayoutTests/platform/ios-simulator-wk2/fast/forms/auto-fill-button/ instead
> of LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/, how did
> you determine it should be "ios-simulator"?
> 

Notice that run-webkit-tests for iOS WebKit2 falls back to the results in LayoutTests/platform/ios-simulator if it cannot find a result in LayoutTests/platform/ios-simulator-wk2 as part of a longer fallback chain. There is an existing expected result in directory LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button and there is no subdirectory named auto-fill-button in LayoutTests/platform/ios-simulator-wk2/fast/forms; => the WebKit2 expected result is the same as the WebKit1 expected result; => we should update the expected result in LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button.

[Zach Li]

Created attachment 274451 [details]
Patch v3

Updated expected result in ios-simulator.

I am not a committer, so I would need someone to help me commit the change.

[WebKit Commit Bot]

Comment on attachment 274451 [details]
Patch v3

Clearing flags on attachment: 274451

Committed r198460: <http://trac.webkit.org/changeset/198460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

Committed updated expected results for Windows and GTK and added expected result for EFL in <http://trac.webkit.org/changeset/198467>.