Bug 155604 – AX: Radio button members are not identified together in all cases

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

1. State VoiceOver on an iOS device
2. Open http://wafflerama.com/a11y/cssposition.html
3. Navigate through the page, listening to the output for each of the radio buttons

Expected Results:
In step 3, the two sets of radio buttons should each enumerate as '1 of 3', etc.

Actual Results:
In step 3, the first 3 radio buttons are all announced as "1 of 1". The second set of radio buttons are properly announced as "1 of 3", etc.

[chris fleizach]

<rdar://problem/21186992>

[Radar WebKit Bug Importer]

<rdar://problem/25227435>

[chris fleizach]

Created attachment 274439 [details]
patch

[WebKit Commit Bot]

Attachment 274439 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:955:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:956:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:957:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:958:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:959:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 274440 [details]
patch

[Darin Adler]

Comment on attachment 274440 [details]
patch

The old code is not the right way to find radio buttons. Code to iterate all the radio buttons in a group should not have been replicated in the accessibility code, but instead should be an interface provide by the HTMLInputElement class. We could have a function:

     Vector<HTMLInputElement*> radioButtonGroup() const;

It would get the misnamed CheckedRadioButtons object, then would take the element's name and find the RadioButtonGroup. That has a HashSet of all the radio buttons in that group and that can be converted into a Vector.

[chris fleizach]

(In reply to comment #6)
> Comment on attachment 274440 [details]
> patch
> 
> The old code is not the right way to find radio buttons. Code to iterate all
> the radio buttons in a group should not have been replicated in the
> accessibility code, but instead should be an interface provide by the
> HTMLInputElement class. We could have a function:
> 
>      Vector<HTMLInputElement*> radioButtonGroup() const;
> 
> It would get the misnamed CheckedRadioButtons object, then would take the
> element's name and find the RadioButtonGroup. That has a HashSet of all the
> radio buttons in that group and that can be converted into a Vector.

I'll follow up with a new patch for that

https://bugs.webkit.org/show_bug.cgi?id=155696

[WebKit Commit Bot]

Comment on attachment 274440 [details]
patch

Clearing flags on attachment: 274440

Committed r198474: <http://trac.webkit.org/changeset/198474>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.