Bug 155595

Summary: Set the WebContent process's main thread QoS to USER-INTERACTIVE
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, kling, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-03-17 12:51:16 PDT
Set the WebContent process's main thread QoS to USER-INTERACTIVE instead of USER-INITIATED to match the UIProcess's main thread QoS. The WebContent process main thread is drawing UI and the policy is to use USER-INTERACTIVE QoS in such case.
Attachments
Patch (4.97 KB, patch)
2016-03-17 12:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2016-03-17 13:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-03-17 12:51:37 PDT
rdar://problem/22534965
Chris Dumez
Comment 2 2016-03-17 12:58:50 PDT
Created attachment 274316 [details] Patch
Chris Dumez
Comment 3 2016-03-17 13:08:02 PDT
Created attachment 274320 [details] Patch
Antti Koivisto
Comment 4 2016-03-17 13:17:26 PDT
We have deliberately used lower priority for web thread/process so it doesn't make scrolling choppy. How have you verified this is not a problem anymore?
Chris Dumez
Comment 5 2016-03-17 13:18:33 PDT
(In reply to comment #4) > We have deliberately used lower priority for web thread/process so it > doesn't make scrolling choppy. How have you verified this is not a problem > anymore We now use the same QoS but the WebContent process still has lower relative priority than the scrolling thread to mitigate the issue as explained in the ChangeLog.
Chris Dumez
Comment 6 2016-03-17 13:23:11 PDT
(In reply to comment #5) > (In reply to comment #4) > > We have deliberately used lower priority for web thread/process so it > > doesn't make scrolling choppy. How have you verified this is not a problem > > anymore > > We now use the same QoS but the WebContent process still has lower relative > priority than the scrolling thread to mitigate the issue as explained in the > ChangeLog. About the verification, scrolling on nytimes.com does not look visibly choppier and I was counting on ScrollPerf to let us know if there is a regression on this front.
Antti Koivisto
Comment 7 2016-03-17 13:43:37 PDT
Comment on attachment 274320 [details] Patch Ok!
Chris Dumez
Comment 8 2016-03-17 13:47:01 PDT
Comment on attachment 274320 [details] Patch Clearing flags on attachment: 274320 Committed r198350: <http://trac.webkit.org/changeset/198350>
Chris Dumez
Comment 9 2016-03-17 13:47:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.