Bug 155579

Summary: Reduce uses of PassRefPtr in WebCore/dom - 6
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2016-03-17 01:08:39 PDT
SSIA
Attachments
Patch (8.48 KB, patch)
2016-03-17 01:09 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (15.73 KB, patch)
2016-03-18 02:23 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (18.28 KB, patch)
2016-03-19 00:44 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (19.75 KB, patch)
2016-03-20 21:24 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2016-03-17 01:09:26 PDT
Created attachment 274269 [details] Patch
Gyuyoung Kim
Comment 2 2016-03-18 02:23:53 PDT
Created attachment 274400 [details] Patch
Gyuyoung Kim
Comment 3 2016-03-19 00:44:54 PDT
Created attachment 274512 [details] Patch
Darin Adler
Comment 4 2016-03-19 09:34:57 PDT
Comment on attachment 274512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274512&action=review Seems like some more of these should be Ref rather than RefPtr; I’m not sure they all need to support nulls. > Source/WebCore/dom/EventContext.h:46 > + EventContext(RefPtr<Node>&&, RefPtr<EventTarget>&& currentTarget, RefPtr<EventTarget>&&); The single code path that makes all of these in EventPath does not pass ownership of anything. All three arguments should be raw pointers, not RefPtr&&.
Gyuyoung Kim
Comment 5 2016-03-20 21:24:15 PDT
Created attachment 274572 [details] Patch
Gyuyoung Kim
Comment 6 2016-03-20 22:13:43 PDT
(In reply to comment #4) > Comment on attachment 274512 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274512&action=review > > Source/WebCore/dom/EventContext.h:46 > > + EventContext(RefPtr<Node>&&, RefPtr<EventTarget>&& currentTarget, RefPtr<EventTarget>&&); > > The single code path that makes all of these in EventPath does not pass > ownership of anything. All three arguments should be raw pointers, not > RefPtr&&. Fixed.
WebKit Commit Bot
Comment 7 2016-03-20 23:05:52 PDT
Comment on attachment 274572 [details] Patch Clearing flags on attachment: 274572 Committed r198483: <http://trac.webkit.org/changeset/198483>
WebKit Commit Bot
Comment 8 2016-03-20 23:05:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.