Bug 155560 – [JSC] allow duplicate property names returned from Proxy ownKeys() trap

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Caitlin Potter (:caitp)]

[JSC] allow duplicate property names returned from Proxy ownKeys() trap

[Caitlin Potter (:caitp)]

Created attachment 274222 [details]
Patch

[Saam Barati]

Comment on attachment 274222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274222&action=review

> Source/JavaScriptCore/runtime/ProxyObject.cpp:879
> +        trapResult.addKnownUnique(ident.impl());

LGTM, but I think it's worth renaming "addKnownUnique"
That functions name has lost its meaning over time. Either in
this patch or another patch.

[Darin Adler]

Comment on attachment 274222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274222&action=review

>> Source/JavaScriptCore/runtime/ProxyObject.cpp:879
>> +        trapResult.addKnownUnique(ident.impl());
> 
> LGTM, but I think it's worth renaming "addKnownUnique"
> That functions name has lost its meaning over time. Either in
> this patch or another patch.

I completely agree. I came here just to write this comment!

[Caitlin Potter (:caitp)]

I haven't been able to come up with a good alternative name, since "addKnownUnique" looks like it makes a lot of sense in the other place it's used

[Saam Barati]

(In reply to comment #4)
> I haven't been able to come up with a good alternative name, since
> "addKnownUnique" looks like it makes a lot of sense in the other place it's
> used

I'll look at the other call sites later today, but just off the top
of my head, what about "append" or "addUnconditionally"?

[Caitlin Potter (:caitp)]

Created attachment 274650 [details]
Patch

[Caitlin Potter (:caitp)]

I've gone with "addUnchecked()", let me know if that works for you guys

[Darin Adler]

Comment on attachment 274650 [details]
Patch

I think the name addUnchecked is OK for now. We should return later and consider renaming the other "add" functions to make it clearer that they enforce uniqueness. Since uniqueness is no longer an invariant of the class, the add function needs to make it clear that it’s a rule it implements.

[WebKit Commit Bot]

Comment on attachment 274650 [details]
Patch

Clearing flags on attachment: 274650

Committed r198531: <http://trac.webkit.org/changeset/198531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.