Bug 155523

Summary:

REGRESSION(r198077): generated Objective-C protocol object getters leak their wrappers

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, hi, inspector-bugzilla-changes, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

155553

Bug Blocks:

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2016-03-15 17:08:10 PDT

Oops, this should be autoreleased.

Comment 1 Radar WebKit Bug Importer 2016-03-15 17:09:06 PDT

<rdar://problem/25181764>

Comment 2 BJ Burg 2016-03-15 17:14:31 PDT

Created attachment 274160 [details]
Proposed Fix

Need to confirm the fix by running static analyzer, but it looks right to me.

Comment 3 WebKit Commit Bot 2016-03-15 17:15:29 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 4 Joseph Pecoraro 2016-03-15 17:15:57 PDT

Comment on attachment 274160 [details]
Proposed Fix

r=me

Comment 5 BJ Burg 2016-03-15 20:31:24 PDT

Committed r198257: <http://trac.webkit.org/changeset/198257>

Comment 6 Timothy Hatcher 2016-03-15 21:18:03 PDT

<rdar://problem/25181764>

Comment 7 WebKit Commit Bot 2016-03-16 11:55:28 PDT

Re-opened since this is blocked by bug 155553