Bug 155511 – Add developer Animometer test that bounces P3-tagged images

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add developer Animometer test that bounces P3-tagged images

[Simon Fraser (smfr)]

Created attachment 274126 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 274128 [details]
Patch

[Jon Lee]

Comment on attachment 274126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274126&action=review

Please make sure the images are the same size.

> PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js:46
> +        this.imageSrc = options["imageSrc"] || "../resources/yin-yang.svg";

Remove, this is not needed.

There are existing tests in the master suite that preload the images prior to initializing the benchmark. Can we do that here?

> PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js:67
> +window.benchmarkClass = BouncingCssImagesBenchmark;

I'd rather go with a name explaining what it's testing and not its visual behavior, like TaggedImageBenchmark, TaggedImageStage, TaggedImageParticle.

> PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js:71
> +/*

please remove.

[Simon Fraser (smfr)]

Created attachment 274131 [details]
Patch

[Jon Lee]

Comment on attachment 274131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274131&action=review

Provisional r=me with the added code.

> PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js:96
> +    }

, {

    waitUntilReady: function() {
        this.readyPromise = new SimplePromise;
        return this.readyPromise;
    }

[Simon Fraser (smfr)]

Created attachment 274133 [details]
Really wait for images to load this time

[Simon Fraser (smfr)]

Created attachment 274134 [details]
Really wait for images to load this time

[Jon Lee]

Comment on attachment 274134 [details]
Really wait for images to load this time

Provisional r=me.

[Simon Fraser (smfr)]

https://trac.webkit.org/r198236