Bug 155510

Summary:

Silence leaks in ParkingLot

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, cdumez, cmarcelo, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ap: review+

Description Filip Pizlo 2016-03-15 14:02:12 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-03-15 14:07:49 PDT

Created attachment 274125 [details]
the patch

Comment 2 Alexey Proskuryakov 2016-03-15 14:13:06 PDT

Comment on attachment 274125 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274125&action=review

> Source/WTF/wtf/ParkingLot.cpp:183
> +Vector<Hashtable*>* hashtables;

Should this be static?

Comment 3 Filip Pizlo 2016-03-15 14:13:44 PDT

(In reply to comment #2)
> Comment on attachment 274125 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274125&action=review
> 
> > Source/WTF/wtf/ParkingLot.cpp:183
> > +Vector<Hashtable*>* hashtables;
> 
> Should this be static?

The whole thing is in an anonymous namespace, so it doesn't have to be.

Comment 4 Alexey Proskuryakov 2016-03-15 14:31:36 PDT

Indeed. See also: <https://lists.macosforge.org/pipermail/webkit-dev/2011-October/018303.html>.

Comment 5 Filip Pizlo 2016-03-17 11:54:46 PDT

Landed in http://trac.webkit.org/changeset/198345