| Summary: | AX: "AXLandmarkApplication" is an inappropriate subrole for ARIA "application" since it's no longer a landmark | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Craig <jcraig> | ||||
| Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, clown, commit-queue, dmazzoni, jdiggs, mario, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari 9 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
James Craig
2016-03-12 18:52:14 PST
Don't use AXApplication since that's reserved for native apps. Chris: Any thoughts on this one? We need to wrap up the mappings for the Core AAM spec. i think we gotta change it everywhere (In reply to comment #4) > i think we gotta change it everywhere Meaning....? (In reply to comment #5) > (In reply to comment #4) > > i think we gotta change it everywhere > > Meaning....? we should change WebCore code so that Application is not a landmark type. i don't know what the new names will be though since we haven't done it (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > i think we gotta change it everywhere > > > > Meaning....? > > we should change WebCore code so that Application is not a landmark type. i > don't know what the new names will be though since we haven't done it Aha. Gotcha. So both for the purpose of making the change everywhere, and also filling out the cell in the table in the spec, if you could sort out what the role, subrole, and role description should be that would be great. Then, if you and Nan are busy, I'm happy to make the change for our platforms once I know what they should be. Thanks again! (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > i think we gotta change it everywhere > > > > > > Meaning....? > > > > we should change WebCore code so that Application is not a landmark type. i > > don't know what the new names will be though since we haven't done it > > Aha. Gotcha. So both for the purpose of making the change everywhere, and > also filling out the cell in the table in the spec, if you could sort out > what the role, subrole, and role description should be that would be great. > > Then, if you and Nan are busy, I'm happy to make the change for our > platforms once I know what they should be. Yes please go ahead. I think you'll be able to make reasonable decisions for all platforms > > Thanks again! Created attachment 276038 [details]
Patch
@Chris: Due to some local build issues I'm having with the iOS Simulator, along with having no Windows environment, I'm tossing this patch at EWS to see what test failures I get before asking for formal review. In the meantime, how do you feel about a subrole of AXWebApplication and a role description of "web application"? I wasn't sure if the role description should be left alone, or if the distinction between a web app and a native/top-level app mattered. (In reply to comment #10) > @Chris: Due to some local build issues I'm having with the iOS Simulator, > along with having no Windows environment, I'm tossing this patch at EWS to > see what test failures I get before asking for formal review. > > In the meantime, how do you feel about a subrole of AXWebApplication and a > role description of "web application"? I wasn't sure if the role description > should be left alone, or if the distinction between a web app and a > native/top-level app mattered. sounds good to me looks like EWS is green (In reply to comment #11) > (In reply to comment #10) > > @Chris: Due to some local build issues I'm having with the iOS Simulator, > > along with having no Windows environment, I'm tossing this patch at EWS to > > see what test failures I get before asking for formal review. > > > > In the meantime, how do you feel about a subrole of AXWebApplication and a > > role description of "web application"? I wasn't sure if the role description > > should be left alone, or if the distinction between a web app and a > > native/top-level app mattered. > > sounds good to me > > looks like EWS is green Yup. Please review then. Thanks! Comment on attachment 276038 [details] Patch Clearing flags on attachment: 276038 Committed r199260: <http://trac.webkit.org/changeset/199260> All reviewed patches have been landed. Closing bug. |