Bug 155388

Summary: REGRESSION (r190840): crash inside details element's slotNameFunction
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ddkilzer, esprehn+autocc, gyuyoung.kim, kangil.han, kling, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Fixes the bug
none
Archive of layout-test-results from ews117 for mac-yosemite none

Description Ryosuke Niwa 2016-03-11 23:14:46 PST
We're doing a bad cast inside slotNameFunction.

<rdar://problem/24610137>.
Comment 1 Ryosuke Niwa 2016-03-11 23:22:25 PST
Created attachment 273814 [details]
Fixes the bug
Comment 2 Build Bot 2016-03-12 00:20:38 PST
Comment on attachment 273814 [details]
Fixes the bug

Attachment 273814 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/964769

New failing tests:
js/function-apply.html
Comment 3 Build Bot 2016-03-12 00:20:44 PST
Created attachment 273818 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Alexey Proskuryakov 2016-03-13 14:17:27 PDT
Filed bug 155411 for EWS false positive.
Comment 5 Ryosuke Niwa 2016-03-13 18:07:26 PDT
Comment on attachment 273814 [details]
Fixes the bug

I don't think I broke function-apply.html with this patch.
Comment 6 WebKit Commit Bot 2016-03-13 18:57:05 PDT
Comment on attachment 273814 [details]
Fixes the bug

Clearing flags on attachment: 273814

Committed r198090: <http://trac.webkit.org/changeset/198090>
Comment 7 WebKit Commit Bot 2016-03-13 18:57:12 PDT
All reviewed patches have been landed.  Closing bug.