| Summary: | [OS X] Scrollbars of overflow:scroll divs should appear on the left on RTL systems | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Myles C. Maxfield
2016-03-11 19:29:23 PST
Created attachment 273796 [details]
WIP
Created attachment 273798 [details]
WIP
Created attachment 273803 [details]
WIP
Created attachment 273804 [details]
WIP
Created attachment 273807 [details]
Patch
Comment on attachment 273807 [details] Patch Attachment 273807 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/964349 New failing tests: fast/scrolling/rtl-scrollbars-overflow-padding.html fast/scrolling/rtl-scrollbars-overflow.html fast/scrolling/rtl-scrollbars-overflow-simple.html fast/scrolling/rtl-scrollbars-overflow-contents.html fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html Created attachment 273811 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 273812 [details]
Patch
Comment on attachment 273812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273812&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:2045 > +bool RenderStyle::shouldPlaceBlockDirectionScrollbarOnLogicalLeft() const "LogicalLeft" makes my brain hurt. Isn't the logical left for RTL actually the right? For logical positions we normally use start/end, so maybe this is PhysicalLeft? Committed r198069: <http://trac.webkit.org/changeset/198069> |