Bug 155385

Summary: [OS X] Scrollbars of overflow:scroll divs should appear on the left on RTL systems
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2016-03-11 19:29:23 PST
[OS X] Scrollbars of overflow:scroll divs should appear on the left on RTL systems
Attachments
WIP (31.46 KB, patch)
2016-03-11 19:30 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (39.73 KB, patch)
2016-03-11 19:40 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (40.84 KB, patch)
2016-03-11 21:55 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (49.05 KB, patch)
2016-03-11 22:02 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (49.99 KB, patch)
2016-03-11 22:13 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (4.47 MB, application/zip)
2016-03-11 22:45 PST, Build Bot 		no flags
Details
Patch (55.87 KB, patch)
2016-03-11 23:05 PST, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-11 19:30:08 PST
Created attachment 273796 [details] WIP
Myles C. Maxfield
Comment 2 2016-03-11 19:40:14 PST
Created attachment 273798 [details] WIP
Myles C. Maxfield
Comment 3 2016-03-11 21:55:57 PST
Created attachment 273803 [details] WIP
Myles C. Maxfield
Comment 4 2016-03-11 22:02:13 PST
Created attachment 273804 [details] WIP
Myles C. Maxfield
Comment 5 2016-03-11 22:13:32 PST
Created attachment 273807 [details] Patch
Build Bot
Comment 6 2016-03-11 22:45:48 PST
Comment on attachment 273807 [details] Patch Attachment 273807 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/964349 New failing tests: fast/scrolling/rtl-scrollbars-overflow-padding.html fast/scrolling/rtl-scrollbars-overflow.html fast/scrolling/rtl-scrollbars-overflow-simple.html fast/scrolling/rtl-scrollbars-overflow-contents.html fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html
Build Bot
Comment 7 2016-03-11 22:45:53 PST
Created attachment 273811 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Myles C. Maxfield
Comment 8 2016-03-11 23:05:53 PST
Created attachment 273812 [details] Patch
Simon Fraser (smfr)
Comment 9 2016-03-11 23:31:34 PST
Comment on attachment 273812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273812&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:2045 > +bool RenderStyle::shouldPlaceBlockDirectionScrollbarOnLogicalLeft() const "LogicalLeft" makes my brain hurt. Isn't the logical left for RTL actually the right? For logical positions we normally use start/end, so maybe this is PhysicalLeft?
Myles C. Maxfield
Comment 10 2016-03-12 13:18:20 PST
Committed r198069: <http://trac.webkit.org/changeset/198069>
Radar WebKit Bug Importer
Comment 11 2016-03-13 20:45:56 PDT
<rdar://problem/25136942>
Note You need to log in before you can comment on or make changes to this bug.