Bug 155349

Summary: Web Automation: add commands to move and resize a browsing context's window
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 155323    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix timothy: review+, bburg: commit-queue-

Blaze Burg
Reported 2016-03-10 22:52:22 PST
.
Attachments
Proposed Fix (9.29 KB, patch)
2016-03-12 00:43 PST, Blaze Burg 		timothy: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-10 22:52:47 PST
<rdar://problem/25104911>
Blaze Burg
Comment 2 2016-03-12 00:43:37 PST
Created attachment 273822 [details] Proposed Fix
Timothy Hatcher
Comment 3 2016-03-12 09:37:06 PST
Comment on attachment 273822 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273822&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:231 > + if (!sizeObject.getDouble(WTF::ASCIILiteral("width"), width)) Why is there no specific protocol object for these? > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:268 > + if (!positionObject.getDouble(WTF::ASCIILiteral("x"), x)) Ditto.
Blaze Burg
Comment 4 2016-03-13 15:09:55 PDT
Comment on attachment 273822 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273822&action=review >> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:231 >> + if (!sizeObject.getDouble(WTF::ASCIILiteral("width"), width)) > > Why is there no specific protocol object for these? There is, but the C++ protocol bindings do not perform checks / type casts for incoming messages like the ObjC bindings do. We rely on each command to do the verification (though in debug builds we go most of the way and assert if required keys are missing). There is a bug open somewhere about fixing this. It's likely to find some wrong and/or missing checks.
Blaze Burg
Comment 5 2016-03-28 15:35:54 PDT
Committed https://trac.webkit.org/r198760.
Note You need to log in before you can comment on or make changes to this bug.