Bug 155348 – Web Inspector: Make it possible to disable TimelineRuler UI

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

* SUMMARY
Make it possible to disable TimelineRuler UI. Disabling the ruler should lock the current selection, and hide the selection handles to emphasize the non-editable state.

* NOTE
If allowsTimeRangeSelection is false, setting disabled = true would have no effect.

[Radar WebKit Bug Importer]

<rdar://problem/25103505>

[Matt Baker]

Created attachment 273680 [details]
[Video] Disabled behavior

Double-click disables the ruler for demo purposes only. In the real world this would be set programmatically.

[Matt Baker]

Created attachment 273682 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 273682 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273682&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:727
> -        this.element.style.pointerEvents = "all";
> +        this.element.style.pointerEvents = pointerEvents;

This could be changed to: delete this.element.style.pointerEvents or this.element.style.pointerEvents = null;

[Matt Baker]

(In reply to comment #4)
> Comment on attachment 273682 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273682&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:727
> > -        this.element.style.pointerEvents = "all";
> > +        this.element.style.pointerEvents = pointerEvents;
> 
> This could be changed to: delete this.element.style.pointerEvents or
> this.element.style.pointerEvents = null;

Both methods results in "" being returned by `this.element.style.pointerEvents`, so I'll go with " = null".

[Matt Baker]

Created attachment 273737 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 273737 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 273737

Committed r198026: <http://trac.webkit.org/changeset/198026>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 273737 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273737&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:722
> -        if (this._mouseMoved)
> +        if (!this._enabled)
> +            return;
> +
> +        if (!this._mouseMoved)
>              return;

This flipped the condition of the mouseMoved check =(.