Summary: | Web Inspector: Make it possible to disable TimelineRuler UI | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 153672 | ||||||||||
Attachments: |
|
Description
Matt Baker
2016-03-10 20:59:35 PST
Created attachment 273680 [details]
[Video] Disabled behavior
Double-click disables the ruler for demo purposes only. In the real world this would be set programmatically.
Created attachment 273682 [details]
[Patch] Proposed Fix
Comment on attachment 273682 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273682&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:727 > - this.element.style.pointerEvents = "all"; > + this.element.style.pointerEvents = pointerEvents; This could be changed to: delete this.element.style.pointerEvents or this.element.style.pointerEvents = null; (In reply to comment #4) > Comment on attachment 273682 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273682&action=review > > > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:727 > > - this.element.style.pointerEvents = "all"; > > + this.element.style.pointerEvents = pointerEvents; > > This could be changed to: delete this.element.style.pointerEvents or > this.element.style.pointerEvents = null; Both methods results in "" being returned by `this.element.style.pointerEvents`, so I'll go with " = null". Created attachment 273737 [details]
[Patch] Proposed Fix
Comment on attachment 273737 [details] [Patch] Proposed Fix Clearing flags on attachment: 273737 Committed r198026: <http://trac.webkit.org/changeset/198026> All reviewed patches have been landed. Closing bug. Comment on attachment 273737 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=273737&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:722 > - if (this._mouseMoved) > + if (!this._enabled) > + return; > + > + if (!this._mouseMoved) > return; This flipped the condition of the mouseMoved check =(. |