Bug 155341

Summary:

[ES6] Make RegExp.prototype.toString spec compliant

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, rniwa, sukolsak, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	fpizlo: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
patch for landing	none
patch for landing v2	none

Saam Barati

Reported 2016-03-10 17:31:30 PST

...

Attachments
patch (5.67 KB, patch) 2016-03-10 18:10 PST, Saam Barati	fpizlo: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (1002.92 KB, application/zip) 2016-03-10 18:38 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (819.75 KB, application/zip) 2016-03-10 18:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (588.98 KB, application/zip) 2016-03-10 19:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.01 MB, application/zip) 2016-03-10 19:35 PST, Build Bot	no flags	Details
patch for landing (9.08 KB, patch) 2016-03-10 19:45 PST, Saam Barati	no flags	Details Formatted Diff Diff
patch for landing v2 (9.15 KB, patch) 2016-03-10 19:46 PST, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2016-03-10 18:10:58 PST

Created attachment 273663 [details] patch

Build Bot

Comment 2 2016-03-10 18:38:12 PST

Comment on attachment 273663 [details] patch Attachment 273663 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/957785 New failing tests: js/regexp-toString.html

Build Bot

Comment 3 2016-03-10 18:38:15 PST

Created attachment 273664 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-03-10 18:57:31 PST

Comment on attachment 273663 [details] patch Attachment 273663 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/957848 New failing tests: js/regexp-toString.html

Build Bot

Comment 5 2016-03-10 18:57:34 PST

Created attachment 273666 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-03-10 19:11:07 PST

Comment on attachment 273663 [details] patch Attachment 273663 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/957863 New failing tests: js/regexp-toString.html

Build Bot

Comment 7 2016-03-10 19:11:10 PST

Created attachment 273667 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5

Saam Barati

Comment 8 2016-03-10 19:30:23 PST

I need to update new results it looks like.

Build Bot

Comment 9 2016-03-10 19:35:14 PST

Comment on attachment 273663 [details] patch Attachment 273663 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/957923 New failing tests: js/regexp-toString.html

Build Bot

Comment 10 2016-03-10 19:35:17 PST

Created attachment 273669 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Saam Barati

Comment 11 2016-03-10 19:45:02 PST

Created attachment 273671 [details] patch for landing

Saam Barati

Comment 12 2016-03-10 19:46:22 PST

Created attachment 273672 [details] patch for landing v2

WebKit Commit Bot

Comment 13 2016-03-10 23:10:06 PST

Comment on attachment 273672 [details] patch for landing v2 Clearing flags on attachment: 273672 Committed r197999: <http://trac.webkit.org/changeset/197999>

WebKit Commit Bot

Comment 14 2016-03-10 23:10:13 PST

All reviewed patches have been landed. Closing bug.

Keith Miller

Comment 15 2016-03-10 23:12:59 PST

Committed r198000: <http://trac.webkit.org/changeset/198000>

Joseph Pecoraro

Comment 16 2016-06-06 20:44:26 PDT

*** Bug 155088 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.