Bug 15532

Summary: run-safari fails if Safari is installed in a non-default location
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch with ChangeLog darin: review+

Adam Roben (:aroben)
Reported 2007-10-16 09:24:38 PDT
WebKitTools/Scripts/run-safari assumes that Safari was installed in %PROGRAMFILES%\Safari (the default location). If Safari is not installed there, run-safari will fail with an error message that "The system cannot find the path specified." We should make run-safari work no matter where Safari is installed. We can possibly reuse some of the logic from WebKitInitializer to find the Safari installation location.
Attachments
Patch with ChangeLog (15.55 KB, patch)
2007-10-16 19:49 PDT, Adam Roben (:aroben) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2007-10-16 19:49:12 PDT
Created attachment 16691 [details] Patch with ChangeLog
Adam Roben (:aroben)
Comment 2 2007-10-16 19:51:48 PDT
Comment on attachment 16691 [details] Patch with ChangeLog I have some more changes coming that will remove the need for WebKitInitializer entirely, which will get rid of the massive code duplication that currently exists between FindSafari and WebKitInitializer.
Darin Adler
Comment 3 2007-10-16 21:59:36 PDT
Comment on attachment 16691 [details] Patch with ChangeLog r=me
Adam Roben (:aroben)
Comment 4 2007-10-17 13:24:03 PDT
Landed as r26706
Gordon Duke
Comment 5 2007-11-26 15:40:09 PST
I am also seeing this issue with Safari installed to %PROGRAMFILES%\Safari and the nightly build webkit (r28023) installed to \webkit. Both off C:
Note You need to log in before you can comment on or make changes to this bug.