Bug 15532

Summary:

run-safari fails if Safari is installed in a non-default location

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch with ChangeLog	darin: review+

Description Adam Roben (:aroben) 2007-10-16 09:24:38 PDT

WebKitTools/Scripts/run-safari assumes that Safari was installed in %PROGRAMFILES%\Safari (the default location). If Safari is not installed there, run-safari will fail with an error message that "The system cannot find the path specified." We should make run-safari work no matter where Safari is installed. We can possibly reuse some of the logic from WebKitInitializer to find the Safari installation location.

Comment 1 Adam Roben (:aroben) 2007-10-16 19:49:12 PDT

Created attachment 16691 [details]
Patch with ChangeLog

Comment 2 Adam Roben (:aroben) 2007-10-16 19:51:48 PDT

Comment on attachment 16691 [details]
Patch with ChangeLog

I have some more changes coming that will remove the need for WebKitInitializer entirely, which will get rid of the massive code duplication that currently exists between FindSafari and WebKitInitializer.

Comment 3 Darin Adler 2007-10-16 21:59:36 PDT

Comment on attachment 16691 [details]
Patch with ChangeLog

r=me

Comment 4 Adam Roben (:aroben) 2007-10-17 13:24:03 PDT

Landed as r26706

Comment 5 Gordon Duke 2007-11-26 15:40:09 PST

I am also seeing this issue with Safari installed to %PROGRAMFILES%\Safari and the nightly build webkit (r28023) installed to \webkit.  Both off C: