Summary: | Retrieve additional context for some data detector link for preview and action menu | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Enrica Casucci
2016-03-09 17:05:34 PST
Created attachment 273516 [details]
Patch
Comment on attachment 273516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273516&action=review > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:446 > + NSMutableDictionary *extendedContext = nil; > + extendedContext = [[[NSMutableDictionary alloc] init] autorelease]; Why autorelease instead of RetainPtr? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3837 > + newContext = [[[NSMutableDictionary alloc] init] autorelease]; Ditto. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2208 > + info.textBefore = plainTextReplacingNoBreakSpace(rangeExpandedByCharactersInDirectionAtWordBoundary(linkRange->startPosition(), 350, DirectionBackward).get(), TextIteratorDefaultBehavior, true); Random 350 in the middle of the line could use constant-ing. Committed revision 197916. |