Summary: | check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, bfulgham, commit-queue, darin, dbates, ddkilzer, glenn, lforschler, thorton | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2016-03-09 15:50:29 PST
Created attachment 273497 [details]
Patch
Comment on attachment 273497 [details]
Patch
Oops, I see a problem with one of the regexes.
Created attachment 273500 [details]
Patch v2
Comment on attachment 273500 [details] Patch v2 Clearing flags on attachment: 273500 Committed r197912: <http://trac.webkit.org/changeset/197912> All reviewed patches have been landed. Closing bug. Comment on attachment 273500 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=273500&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2429 > - and not search(r'\b(if|for|while|switch|NS_ENUM)\b', line) > + and not search(r'(\b(if|for|while|switch|NS_ENUM)|} @catch)\b', line) For posterity r'(\b(if|for|while|switch|NS_ENUM|@catch)\b' doesn't work because the pattern '\b@catch\b' doesn't match '} @catch (NSException *exception){\n', presumably since '@' is not considered the start of a word. |